From: Jiri Olsa <jolsa@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: peterz@infradead.org, acme@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, namhyung@kernel.org,
mingo@redhat.com, irogers@google.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
kjain@linux.ibm.com, james.clark@arm.com
Subject: Re: [PATCH v2 2/2] perf jevents: Enable warnings through HOSTCFLAGS
Date: Thu, 21 Oct 2021 14:48:47 +0200 [thread overview]
Message-ID: <YXFhr2YoVp9GPsDM@krava> (raw)
In-Reply-To: <1634807805-40093-3-git-send-email-john.garry@huawei.com>
On Thu, Oct 21, 2021 at 05:16:45PM +0800, John Garry wrote:
> Currently no compiler warnings at all are enabled for building jevents,
> so help catch bugs at compile time by enabling through HOSTCFLAGS.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> tools/perf/Makefile.config | 5 +++++
> tools/perf/Makefile.perf | 2 +-
> tools/perf/pmu-events/Build | 2 +-
> 3 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 0ae2e3d8b832..374f65b52157 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -17,6 +17,7 @@ detected = $(shell echo "$(1)=y" >> $(OUTPUT).config-detected)
> detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)
>
> CFLAGS := $(EXTRA_CFLAGS) $(filter-out -Wnested-externs,$(EXTRA_WARNINGS))
> +HOSTCFLAGS := $(filter-out -Wnested-externs,$(EXTRA_WARNINGS))
>
> include $(srctree)/tools/scripts/Makefile.arch
>
> @@ -211,6 +212,7 @@ endif
> ifneq ($(WERROR),0)
> CORE_CFLAGS += -Werror
> CXXFLAGS += -Werror
> + HOSTCFLAGS += -Werror
> endif
>
> ifndef DEBUG
> @@ -292,6 +294,9 @@ CXXFLAGS += -ggdb3
> CXXFLAGS += -funwind-tables
> CXXFLAGS += -Wno-strict-aliasing
>
> +HOSTCFLAGS += -Wall
> +HOSTCFLAGS += -Wextra
> +
> # Enforce a non-executable stack, as we may regress (again) in the future by
> # adding assembler files missing the .GNU-stack linker note.
> LDFLAGS += -Wl,-z,noexecstack
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 7df13e74450c..118bcdc70bb4 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -226,7 +226,7 @@ else
> endif
>
> export srctree OUTPUT RM CC CXX LD AR CFLAGS CXXFLAGS V BISON FLEX AWK
> -export HOSTCC HOSTLD HOSTAR
> +export HOSTCC HOSTLD HOSTAR HOSTCFLAGS
>
> include $(srctree)/tools/build/Makefile.include
>
> diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
> index a055dee6a46a..d5c287f069a2 100644
> --- a/tools/perf/pmu-events/Build
> +++ b/tools/perf/pmu-events/Build
> @@ -1,7 +1,7 @@
> hostprogs := jevents
>
> jevents-y += json.o jsmn.o jevents.o
> -HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include
> +HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include $(HOSTCFLAGS)
so the the host cflags are made of:
host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(KBUILD_HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj))
can't you use KBUILD_HOSTCFLAGS?
also perhaps we could rename KBUILD_HOSTCFLAGS to HOSTCFLAGS?
the name seems like leftover from kbuild move
jirka
> pmu-events-y += pmu-events.o
> JDIR = pmu-events/arch/$(SRCARCH)
> JSON = $(shell [ -d $(JDIR) ] && \
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-10-21 12:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 9:16 [PATCH v2 0/2] perf jevents: Enable build warnings John Garry
2021-10-21 9:16 ` [PATCH v2 1/2] perf jevents: Fix some would-be warnings John Garry
2021-10-21 9:16 ` [PATCH v2 2/2] perf jevents: Enable warnings through HOSTCFLAGS John Garry
2021-10-21 12:48 ` Jiri Olsa [this message]
2021-10-21 15:50 ` John Garry
2021-10-21 15:58 ` Jiri Olsa
2021-10-22 9:42 ` John Garry
2021-10-25 11:40 ` Jiri Olsa
2021-10-25 16:20 ` Arnaldo Carvalho de Melo
2021-10-28 8:23 ` John Garry
2021-10-28 11:17 ` Arnaldo Carvalho de Melo
2021-10-28 11:40 ` John Garry
2021-10-21 12:55 ` [PATCH v2 0/2] perf jevents: Enable build warnings Arnaldo Carvalho de Melo
2021-10-21 13:02 ` John Garry
2021-10-21 14:36 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXFhr2YoVp9GPsDM@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).