From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46372C433EF for ; Thu, 21 Oct 2021 15:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B9466120C for ; Thu, 21 Oct 2021 15:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231828AbhJUQAc (ORCPT ); Thu, 21 Oct 2021 12:00:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24509 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231839AbhJUQAb (ORCPT ); Thu, 21 Oct 2021 12:00:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634831893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VfpACOZctT0RhCg7latmNH+ENpS2vqEqG/eWd+re1mY=; b=QziaWjvuE+smOOKB7jXw2Uf+a03TfE9bbrBQvHkgMdh/hxM7+smCdubPJ3nufv9yitWars Hgofr+lE1NpEtDm1K1oKemzYS/lAgipIQCv/xQRVZWf6dRUJOO393jdpzeQ2vfvj8QyBRX RsowAugM/kcLCNgjPcw1QSy5zQ/6QFA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-519-jm1wwpN_N-i80CzD7jZQBw-1; Thu, 21 Oct 2021 11:58:12 -0400 X-MC-Unique: jm1wwpN_N-i80CzD7jZQBw-1 Received: by mail-wr1-f70.google.com with SMTP id a15-20020a056000188f00b00161068d8461so44731wri.11 for ; Thu, 21 Oct 2021 08:58:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VfpACOZctT0RhCg7latmNH+ENpS2vqEqG/eWd+re1mY=; b=GqIW1Csu2sVK5Sn83JFUhYvugl1hruOytIIklR8S/msuPENluJ8kyoaZ07uAzoQRMm G/tpJxoueQX4smTfRIyUeDWIqkh47Uweav99QzaHKG16cJCI0ERr3BchYKO8BLYWTcJ+ eb5u/wUqxmmHtiB3wyca2WLKeuFF+ITYz7+FASr+H47V+2Y6kzHGjUU1AGYxlxrgYQIB cVvvo+oh0FyahQcRyXXRZrVARtugYD3mLt3+n7pxjf6ml/tprO+Ackim0u57qrEUjWiB 8Vw1Fuu6DmRENlF9+2DZvecQnAU54E8I9kt4xo7SlnaphGV9gq77AmM6bFgO5a8qRJu7 OAHw== X-Gm-Message-State: AOAM533hEFFAzsS9sJFE4bED1A9wrXIL2b5QKLFgZRQ9QdliimScRmJM 1Xs+aGuY8x7qzmHLLa/50ch41PPsxnHkSEu/LQyGq1XLUqAmH+QOI6APeQI1i3dI6ZN6y8pjKq7 c5eQOPZ4e1MdNZR33wjE4Cs8Bjx6GtA== X-Received: by 2002:a1c:7dcc:: with SMTP id y195mr988214wmc.18.1634831891400; Thu, 21 Oct 2021 08:58:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyO7pXOflrAQi/8QFCQATA/d84nibFh3NwUmFnriNy9h3nvirMWb+xiNwlUPnLYnkiVTf4qZQ== X-Received: by 2002:a1c:7dcc:: with SMTP id y195mr988188wmc.18.1634831891154; Thu, 21 Oct 2021 08:58:11 -0700 (PDT) Received: from krava (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id f17sm198213wmf.44.2021.10.21.08.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 08:58:10 -0700 (PDT) Date: Thu, 21 Oct 2021 17:58:09 +0200 From: Jiri Olsa To: John Garry Cc: peterz@infradead.org, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, mingo@redhat.com, irogers@google.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kjain@linux.ibm.com, james.clark@arm.com Subject: Re: [PATCH v2 2/2] perf jevents: Enable warnings through HOSTCFLAGS Message-ID: References: <1634807805-40093-1-git-send-email-john.garry@huawei.com> <1634807805-40093-3-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Thu, Oct 21, 2021 at 04:50:09PM +0100, John Garry wrote: > On 21/10/2021 13:48, Jiri Olsa wrote: > > > +HOSTCFLAGS += -Wall > > > +HOSTCFLAGS += -Wextra > > > + > > > # Enforce a non-executable stack, as we may regress (again) in the future by > > > # adding assembler files missing the .GNU-stack linker note. > > > LDFLAGS += -Wl,-z,noexecstack > > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > > > index 7df13e74450c..118bcdc70bb4 100644 > > > --- a/tools/perf/Makefile.perf > > > +++ b/tools/perf/Makefile.perf > > > @@ -226,7 +226,7 @@ else > > > endif > > > export srctree OUTPUT RM CC CXX LD AR CFLAGS CXXFLAGS V BISON FLEX AWK > > > -export HOSTCC HOSTLD HOSTAR > > > +export HOSTCC HOSTLD HOSTAR HOSTCFLAGS > > > include $(srctree)/tools/build/Makefile.include > > > diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build > > > index a055dee6a46a..d5c287f069a2 100644 > > > --- a/tools/perf/pmu-events/Build > > > +++ b/tools/perf/pmu-events/Build > > > @@ -1,7 +1,7 @@ > > > hostprogs := jevents > > > jevents-y += json.o jsmn.o jevents.o > > > -HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include > > > +HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include $(HOSTCFLAGS) > > so the the host cflags are made of: > > > > host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(KBUILD_HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj)) > > > > can't you use KBUILD_HOSTCFLAGS? > > Maybe. However, it seems to be empty when building perf/pmu-events. Even in > building tools/objtool - which currently references it - it is empty AFAICS. > I'm not sure if it's being imported properly. > I meant change like this (on top of yours) jirka --- diff --git a/tools/build/Build.include b/tools/build/Build.include index 2cf3b1bde86e..c2a95ab47379 100644 --- a/tools/build/Build.include +++ b/tools/build/Build.include @@ -99,7 +99,7 @@ cxx_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CXXFLAGS) -D"BUILD_STR(s)=\#s" $(CXX ### ## HOSTCC C flags -host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(KBUILD_HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj)) +host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj)) # output directory for tests below TMPOUT = .tmp_$$$$ diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 0ae2e3d8b832..374f65b52157 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -17,6 +17,7 @@ detected = $(shell echo "$(1)=y" >> $(OUTPUT).config-detected) detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected) CFLAGS := $(EXTRA_CFLAGS) $(filter-out -Wnested-externs,$(EXTRA_WARNINGS)) +HOSTCFLAGS := $(filter-out -Wnested-externs,$(EXTRA_WARNINGS)) include $(srctree)/tools/scripts/Makefile.arch @@ -211,6 +212,7 @@ endif ifneq ($(WERROR),0) CORE_CFLAGS += -Werror CXXFLAGS += -Werror + HOSTCFLAGS += -Werror endif ifndef DEBUG @@ -292,6 +294,9 @@ CXXFLAGS += -ggdb3 CXXFLAGS += -funwind-tables CXXFLAGS += -Wno-strict-aliasing +HOSTCFLAGS += -Wall +HOSTCFLAGS += -Wextra + # Enforce a non-executable stack, as we may regress (again) in the future by # adding assembler files missing the .GNU-stack linker note. LDFLAGS += -Wl,-z,noexecstack diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 7df13e74450c..118bcdc70bb4 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -226,7 +226,7 @@ else endif export srctree OUTPUT RM CC CXX LD AR CFLAGS CXXFLAGS V BISON FLEX AWK -export HOSTCC HOSTLD HOSTAR +export HOSTCC HOSTLD HOSTAR HOSTCFLAGS include $(srctree)/tools/build/Makefile.include