From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4F64C433F5 for ; Wed, 27 Oct 2021 20:00:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 886F26103C for ; Wed, 27 Oct 2021 20:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243758AbhJ0UCZ (ORCPT ); Wed, 27 Oct 2021 16:02:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:51296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231203AbhJ0UCZ (ORCPT ); Wed, 27 Oct 2021 16:02:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 11CF960FC0; Wed, 27 Oct 2021 19:59:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635364799; bh=95aqk1aRn7tZ9u+3WCvanSfI4O5EsROtAUHFrGE9ue8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s+Jg5mZjmNH9pMl1Xcx93PC0SAt/BKDR+KEhTThVkOY1EsNwnnRX2NzGZr8twQvfh rxHmdMIpRKHc2XwDojDeCoAun6jOMnaT4vplhEbwRhINdsAPqvTFhzMjeUNaGxdE1k eB/nnsbnrBxlW4r4TIwylDGGXg8ej9hUCmyMkth2W5SIMf1eHVeBGBdchNQaObhIeO v7m3XoTp1/OqUyMoVi6d/9a4gakhGBwhf9wUmgmAksYyJCSNIwGTV7zbkIIQAD+2gD GQqk9BwGLtlb4a0cYo/VXxFgOV14Lvdq7VWCo27gTvuIAI3CqWNcAzIFbEZaQNV3qz xR5wtZHGQLFBg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 21A8A410A1; Wed, 27 Oct 2021 16:59:53 -0300 (-03) Date: Wed, 27 Oct 2021 16:59:53 -0300 From: Arnaldo Carvalho de Melo To: Mark Wielaard Cc: Jiri Olsa , Sukadev Bhattiprolu , lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Namhyung Kim , Alexander Shishkin , Michael Petlan , Ian Rogers , linux-perf-users@vger.kernel.org Subject: Re: [PATCH] perf tools: Fix compilation on powerpc Message-ID: References: <20210928195253.1267023-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Tue, Sep 28, 2021 at 10:39:05PM +0200, Mark Wielaard escreveu: > Hi, > > On Tue, Sep 28, 2021 at 09:52:53PM +0200, Jiri Olsa wrote: > > Got following build fail on powerpc: > > > > CC arch/powerpc/util/skip-callchain-idx.o > > In function ‘check_return_reg’, > > inlined from ‘check_return_addr’ at arch/powerpc/util/skip-callchain-idx.c:213:7, > > inlined from ‘arch_skip_callchain_idx’ at arch/powerpc/util/skip-callchain-idx.c:265:7: > > arch/powerpc/util/skip-callchain-idx.c:54:18: error: ‘dwarf_frame_register’ accessing 96 bytes \ > > in a region of size 64 [-Werror=stringop-overflow=] > > 54 | result = dwarf_frame_register(frame, ra_regno, ops_mem, &ops, &nops); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > arch/powerpc/util/skip-callchain-idx.c: In function ‘arch_skip_callchain_idx’: > > arch/powerpc/util/skip-callchain-idx.c:54:18: note: referencing argument 3 of type ‘Dwarf_Op *’ > > In file included from /usr/include/elfutils/libdwfl.h:32, > > from arch/powerpc/util/skip-callchain-idx.c:10: > > /usr/include/elfutils/libdw.h:1069:12: note: in a call to function ‘dwarf_frame_register’ > > 1069 | extern int dwarf_frame_register (Dwarf_Frame *frame, int regno, > > | ^~~~~~~~~~~~~~~~~~~~ > > cc1: all warnings being treated as errors > > > > The dwarf_frame_register args changed with [1], > > Updating ops_mem accordingly. > > > > [1] https://sourceware.org/git/?p=elfutils.git;a=commit;h=5621fe5443da23112170235dd5cac161e5c75e65 > > The warning (new with GCC11) and the fix are correct. I'm taking this as an Acked-by, ok? - Arnaldo > The code probably worked fine before because the next var on the stack > was the dummy Dwarf_Op which would have been as if the ops_mem[2] was > actually ops_mem[3] already. You don't need the dummy var now and > Dwarf_Op *ops doesn't need to be initialized (the dwarf_frame_register > will initialize it). > > Note that [1] didn't change the args of the dwarf_frame_register, but > did fix a similar bug in one of the elfutils own tests (and updated > the comment on the function to hopefully be more clear). > > Cheers, > > Mark > > > Cc: Mark Wielaard > > Cc: Sukadev Bhattiprolu > > Signed-off-by: Jiri Olsa > > --- > > tools/perf/arch/powerpc/util/skip-callchain-idx.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c b/tools/perf/arch/powerpc/util/skip-callchain-idx.c > > index 3018a054526a..20cd6244863b 100644 > > --- a/tools/perf/arch/powerpc/util/skip-callchain-idx.c > > +++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c > > @@ -45,7 +45,7 @@ static const Dwfl_Callbacks offline_callbacks = { > > */ > > static int check_return_reg(int ra_regno, Dwarf_Frame *frame) > > { > > - Dwarf_Op ops_mem[2]; > > + Dwarf_Op ops_mem[3]; > > Dwarf_Op dummy; > > Dwarf_Op *ops = &dummy; > > size_t nops; > > -- > > 2.31.1 > > -- - Arnaldo