linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] arm-spe/cs-etm: Print size using consistent format
@ 2021-11-09 14:21 German Gomez
  2021-11-09 14:21 ` [PATCH v2 1/2] perf cs-etm: " German Gomez
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: German Gomez @ 2021-11-09 14:21 UTC (permalink / raw)
  To: linux-kernel, linux-perf-users, acme
  Cc: German Gomez, John Garry, Will Deacon, Mathieu Poirier, Leo Yan,
	Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
	Mike Leach, linux-arm-kernel, coresight

Sent as a splitted re-roll of patchset [1] to keep the patches more
semantically grouped. The patches themselves have been tested and
reviewed in the previous submission already.

Changes since v1:
  - Sent as a separate patchset.
  - Added acme to the recipients list as I forgot to include him in [1].

[1] https://lore.kernel.org/all/20210916154635.1525-1-german.gomez@arm.com/

Andrew Kilroy (2):
  perf cs-etm: Print size using consistent format
  perf arm-spe: Print size using consistent format

 tools/perf/util/arm-spe.c | 2 +-
 tools/perf/util/cs-etm.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/2] perf cs-etm: Print size using consistent format
  2021-11-09 14:21 [PATCH v2 0/2] arm-spe/cs-etm: Print size using consistent format German Gomez
@ 2021-11-09 14:21 ` German Gomez
  2021-11-09 14:21 ` [PATCH v2 2/2] perf arm-spe: " German Gomez
  2021-11-11 17:48 ` [PATCH v2 0/2] arm-spe/cs-etm: " Arnaldo Carvalho de Melo
  2 siblings, 0 replies; 4+ messages in thread
From: German Gomez @ 2021-11-09 14:21 UTC (permalink / raw)
  To: linux-kernel, linux-perf-users, acme
  Cc: Andrew Kilroy, James Clark, German Gomez, Leo Yan,
	Mathieu Poirier, John Garry, Will Deacon, Mark Rutland,
	Alexander Shishkin, Jiri Olsa, Namhyung Kim, Mike Leach,
	linux-arm-kernel, coresight

From: Andrew Kilroy <andrew.kilroy@arm.com>

Since the size is already printed earlier in hex, print the same data
using the same format, in hex.

Reviewed-by: James Clark <james.clark@arm.com>
Signed-off-by: Andrew Kilroy <andrew.kilroy@arm.com>
Signed-off-by: German Gomez <german.gomez@arm.com>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
 tools/perf/util/cs-etm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
index f323adb1a..4f672f7d0 100644
--- a/tools/perf/util/cs-etm.c
+++ b/tools/perf/util/cs-etm.c
@@ -537,7 +537,7 @@ static void cs_etm__dump_event(struct cs_etm_queue *etmq,
 
 	fprintf(stdout, "\n");
 	color_fprintf(stdout, color,
-		     ". ... CoreSight %s Trace data: size %zu bytes\n",
+		     ". ... CoreSight %s Trace data: size %#zx bytes\n",
 		     cs_etm_decoder__get_name(etmq->decoder), buffer->size);
 
 	do {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] perf arm-spe: Print size using consistent format
  2021-11-09 14:21 [PATCH v2 0/2] arm-spe/cs-etm: Print size using consistent format German Gomez
  2021-11-09 14:21 ` [PATCH v2 1/2] perf cs-etm: " German Gomez
@ 2021-11-09 14:21 ` German Gomez
  2021-11-11 17:48 ` [PATCH v2 0/2] arm-spe/cs-etm: " Arnaldo Carvalho de Melo
  2 siblings, 0 replies; 4+ messages in thread
From: German Gomez @ 2021-11-09 14:21 UTC (permalink / raw)
  To: linux-kernel, linux-perf-users, acme
  Cc: Andrew Kilroy, James Clark, German Gomez, Leo Yan, John Garry,
	Will Deacon, Mathieu Poirier, Mark Rutland, Alexander Shishkin,
	Jiri Olsa, Namhyung Kim, Mike Leach, linux-arm-kernel, coresight

From: Andrew Kilroy <andrew.kilroy@arm.com>

Since the size is already printed earlier in hex, print the same data
using the same format, in hex.

Reviewed-by: James Clark <james.clark@arm.com>
Signed-off-by: Andrew Kilroy <andrew.kilroy@arm.com>
Signed-off-by: German Gomez <german.gomez@arm.com>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
---
 tools/perf/util/arm-spe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c
index 58b7069c5..219629197 100644
--- a/tools/perf/util/arm-spe.c
+++ b/tools/perf/util/arm-spe.c
@@ -100,7 +100,7 @@ static void arm_spe_dump(struct arm_spe *spe __maybe_unused,
 	const char *color = PERF_COLOR_BLUE;
 
 	color_fprintf(stdout, color,
-		      ". ... ARM SPE data: size %zu bytes\n",
+		      ". ... ARM SPE data: size %#zx bytes\n",
 		      len);
 
 	while (len) {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/2] arm-spe/cs-etm: Print size using consistent format
  2021-11-09 14:21 [PATCH v2 0/2] arm-spe/cs-etm: Print size using consistent format German Gomez
  2021-11-09 14:21 ` [PATCH v2 1/2] perf cs-etm: " German Gomez
  2021-11-09 14:21 ` [PATCH v2 2/2] perf arm-spe: " German Gomez
@ 2021-11-11 17:48 ` Arnaldo Carvalho de Melo
  2 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-11-11 17:48 UTC (permalink / raw)
  To: German Gomez
  Cc: linux-kernel, linux-perf-users, John Garry, Will Deacon,
	Mathieu Poirier, Leo Yan, Mark Rutland, Alexander Shishkin,
	Jiri Olsa, Namhyung Kim, Mike Leach, linux-arm-kernel, coresight

Em Tue, Nov 09, 2021 at 02:21:51PM +0000, German Gomez escreveu:
> Sent as a splitted re-roll of patchset [1] to keep the patches more
> semantically grouped. The patches themselves have been tested and
> reviewed in the previous submission already.
> 
> Changes since v1:
>   - Sent as a separate patchset.
>   - Added acme to the recipients list as I forgot to include him in [1].

Thanks, applied.

- Arnaldo

 
> [1] https://lore.kernel.org/all/20210916154635.1525-1-german.gomez@arm.com/
> 
> Andrew Kilroy (2):
>   perf cs-etm: Print size using consistent format
>   perf arm-spe: Print size using consistent format
> 
>  tools/perf/util/arm-spe.c | 2 +-
>  tools/perf/util/cs-etm.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.25.1

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-11 17:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-09 14:21 [PATCH v2 0/2] arm-spe/cs-etm: Print size using consistent format German Gomez
2021-11-09 14:21 ` [PATCH v2 1/2] perf cs-etm: " German Gomez
2021-11-09 14:21 ` [PATCH v2 2/2] perf arm-spe: " German Gomez
2021-11-11 17:48 ` [PATCH v2 0/2] arm-spe/cs-etm: " Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).