From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 062B3C433F5 for ; Sat, 6 Nov 2021 19:03:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D69076108C for ; Sat, 6 Nov 2021 19:03:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234871AbhKFTF5 (ORCPT ); Sat, 6 Nov 2021 15:05:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:53796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232523AbhKFTF4 (ORCPT ); Sat, 6 Nov 2021 15:05:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B87D161076; Sat, 6 Nov 2021 19:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636225394; bh=dvJnVXtykJb5fOfhANDIzNUpNdbIdocyte+fty4l+uE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Um5YP6q9WrJXqkaI10osNjoBSPL81UNr2Rm64XOjiCh984ABlEZ3O/IAwes7dY842 n2wO4p0OC6FR54Td2sfYhhWXSkfIX288ty+XzrKVgDdCCxNiHWQpJt+ra4g+c14p/m MYwF2Gxtg1z9jgUwPXgziPme/bHgMxk5WU07tzPyUiyX+bCaHPfIrgnhPKjMgvbYGc NzfqegzNYscfjzFDUoqV6Yw7OXa+5gG2mHgF16Zaa7dtS7WDTtMJxsicGJL9oP38eX REZCjvOmR/rxgD5NTB5yeCaCo+9JX0nJZ30sEFATRxzoQS37veDhM/5WifHZzdsGsf glMsXIrqF600Q== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 693C8410A1; Sat, 6 Nov 2021 16:03:12 -0300 (-03) Date: Sat, 6 Nov 2021 16:03:12 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Song Liu , linux-kernel@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Yonghong Song , John Fastabend , KP Singh , Tiezhu Yang , linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH 2/2] perf bpf: Add missing free to bpf_event__print_bpf_prog_info Message-ID: References: <20211106053733.3580931-1-irogers@google.com> <20211106053733.3580931-2-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211106053733.3580931-2-irogers@google.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, Nov 05, 2021 at 10:37:33PM -0700, Ian Rogers escreveu: > If btf__new is called then there needs to be a corresponding btf__free. Thanks, applied. - Arnaldo > Fixes: f8dfeae009ef ("perf bpf: Show more BPF program info in print_bpf_prog_info()") > Signed-off-by: Ian Rogers > --- > tools/perf/util/bpf-event.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/bpf-event.c b/tools/perf/util/bpf-event.c > index 0783b464777a..1f813d8bb946 100644 > --- a/tools/perf/util/bpf-event.c > +++ b/tools/perf/util/bpf-event.c > @@ -579,7 +579,7 @@ void bpf_event__print_bpf_prog_info(struct bpf_prog_info *info, > synthesize_bpf_prog_name(name, KSYM_NAME_LEN, info, btf, 0); > fprintf(fp, "# bpf_prog_info %u: %s addr 0x%llx size %u\n", > info->id, name, prog_addrs[0], prog_lens[0]); > - return; > + goto out; > } > > fprintf(fp, "# bpf_prog_info %u:\n", info->id); > @@ -589,4 +589,6 @@ void bpf_event__print_bpf_prog_info(struct bpf_prog_info *info, > fprintf(fp, "# \tsub_prog %u: %s addr 0x%llx size %u\n", > i, name, prog_addrs[i], prog_lens[i]); > } > +out: > + btf__free(btf); > } > -- > 2.34.0.rc0.344.g81b53c2807-goog -- - Arnaldo