From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
John Garry <john.garry@huawei.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
eranian@google.com
Subject: Re: [PATCH] perf stat: Fix memory leak on error path
Date: Sun, 7 Nov 2021 12:33:07 -0300 [thread overview]
Message-ID: <YYfxsyAdpMXIchQw@kernel.org> (raw)
In-Reply-To: <20211107085444.3781604-1-irogers@google.com>
Em Sun, Nov 07, 2021 at 01:54:44AM -0700, Ian Rogers escreveu:
> Strdup is used to deduplicate, ensure it isn't overwriting an already
s/overwriting/leaking/g
Right?
- Arnaldo
> created string by freeing first.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/stat-shadow.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
> index 69f3cf3b4a44..e4fb02b05130 100644
> --- a/tools/perf/util/stat-shadow.c
> +++ b/tools/perf/util/stat-shadow.c
> @@ -444,6 +444,7 @@ void perf_stat__collect_metric_expr(struct evlist *evsel_list)
> "Add %s event to groups to get metric expression for %s\n",
> metric_name,
> counter->name);
> + free(printed);
> printed = strdup(metric_name);
> }
> invalid = true;
> --
> 2.34.0.rc0.344.g81b53c2807-goog
--
- Arnaldo
prev parent reply other threads:[~2021-11-07 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 8:54 [PATCH] perf stat: Fix memory leak on error path Ian Rogers
2021-11-07 15:33 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYfxsyAdpMXIchQw@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).