From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Ian Rogers <irogers@google.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 18/59] libperf: Move group_name to perf_evsel
Date: Mon, 8 Nov 2021 22:19:40 +0100 [thread overview]
Message-ID: <YYmUbGz8ZOSnldyy@krava> (raw)
In-Reply-To: <D3BB2601-12C9-46D4-82E3-4E2F47604F14@gmail.com>
On Mon, Nov 08, 2021 at 03:07:05PM -0300, Arnaldo Carvalho de Melo wrote:
>
>
> On November 8, 2021 2:58:39 PM GMT-03:00, Ian Rogers <irogers@google.com> wrote:
> >On Mon, Nov 8, 2021 at 5:39 AM Jiri Olsa <jolsa@redhat.com> wrote:
> >>
> >> Moving group_name to perf_evsel struct.
> >>
> >> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> >> ---
> >> tools/lib/perf/include/internal/evsel.h | 1 +
> >> tools/perf/tests/parse-events.c | 32 ++++++++++++-------------
> >> tools/perf/util/auxtrace.c | 6 ++---
> >> tools/perf/util/evsel.c | 10 ++++----
> >> tools/perf/util/evsel.h | 1 -
> >> tools/perf/util/evsel_fprintf.c | 2 +-
> >> tools/perf/util/header.c | 6 ++---
> >> tools/perf/util/parse-events.c | 4 ++--
> >> 8 files changed, 31 insertions(+), 31 deletions(-)
> >>
> >> diff --git a/tools/lib/perf/include/internal/evsel.h b/tools/lib/perf/include/internal/evsel.h
> >> index 81df282fa008..befcd180ef3d 100644
> >> --- a/tools/lib/perf/include/internal/evsel.h
> >> +++ b/tools/lib/perf/include/internal/evsel.h
> >> @@ -64,6 +64,7 @@ struct perf_evsel {
> >> */
> >> struct {
> >> char *name;
> >> + const char *group_name;
> >
> >I like the constification here. But why constify group_name and not
> >name as well?
>
>
> Can be done in a separate patch, in other series, no?
>
> I understand that he probably is taking advantage of this move do constify 'group_name', but then, looks unrelated too this move to libperf as well.
definitely separate patch, to have the move separated.. perhaps someone
could do constification patchset ;-) I'll put this one on top of the
patchset
thanks,
jirka
>
> - Arnaldo
>
>
>
> >
> >Thanks,
> >Ian
> >
> >> bool auto_merge_stats;
> >> struct list_head config_terms;
> >> const char *metric_id;
> >> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> >> index 15d6d3d907b7..50746bb524f0 100644
> >> --- a/tools/perf/tests/parse-events.c
> >> +++ b/tools/perf/tests/parse-events.c
> >> @@ -782,7 +782,7 @@ static int test__group3(struct evlist *evlist __maybe_unused)
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel));
> >> TEST_ASSERT_VAL("wrong group name",
> >> - !strcmp(leader->group_name, "group1"));
> >> + !strcmp(leader->core.group_name, "group1"));
> >> TEST_ASSERT_VAL("wrong core.nr_members", evsel->core.nr_members == 2);
> >> TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) == 0);
> >> TEST_ASSERT_VAL("wrong sample_read", !evsel->core.sample_read);
> >> @@ -800,7 +800,7 @@ static int test__group3(struct evlist *evlist __maybe_unused)
> >> TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", evsel->core.attr.precise_ip == 3);
> >> TEST_ASSERT_VAL("wrong leader", evsel__has_leader(evsel, leader));
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) == 1);
> >> TEST_ASSERT_VAL("wrong sample_read", !evsel->core.sample_read);
> >>
> >> @@ -817,7 +817,7 @@ static int test__group3(struct evlist *evlist __maybe_unused)
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel));
> >> TEST_ASSERT_VAL("wrong group name",
> >> - !strcmp(leader->group_name, "group2"));
> >> + !strcmp(leader->core.group_name, "group2"));
> >> TEST_ASSERT_VAL("wrong core.nr_members", evsel->core.nr_members == 2);
> >> TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) == 0);
> >> TEST_ASSERT_VAL("wrong sample_read", !evsel->core.sample_read);
> >> @@ -872,7 +872,7 @@ static int test__group4(struct evlist *evlist __maybe_unused)
> >> TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest);
> >> TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", evsel->core.attr.precise_ip == 1);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel));
> >> TEST_ASSERT_VAL("wrong core.nr_members", evsel->core.nr_members == 2);
> >> TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) == 0);
> >> @@ -915,7 +915,7 @@ static int test__group5(struct evlist *evlist __maybe_unused)
> >> TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest);
> >> TEST_ASSERT_VAL("wrong exclude host", evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel));
> >> TEST_ASSERT_VAL("wrong core.nr_members", evsel->core.nr_members == 2);
> >> TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) == 0);
> >> @@ -947,7 +947,7 @@ static int test__group5(struct evlist *evlist __maybe_unused)
> >> TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest);
> >> TEST_ASSERT_VAL("wrong exclude host", evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel));
> >> TEST_ASSERT_VAL("wrong core.nr_members", evsel->core.nr_members == 2);
> >> TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) == 0);
> >> @@ -1001,7 +1001,7 @@ static int test__group_gh1(struct evlist *evlist)
> >> TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest);
> >> TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel));
> >> TEST_ASSERT_VAL("wrong core.nr_members", evsel->core.nr_members == 2);
> >> TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) == 0);
> >> @@ -1041,7 +1041,7 @@ static int test__group_gh2(struct evlist *evlist)
> >> TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest);
> >> TEST_ASSERT_VAL("wrong exclude host", evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel));
> >> TEST_ASSERT_VAL("wrong core.nr_members", evsel->core.nr_members == 2);
> >> TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) == 0);
> >> @@ -1081,7 +1081,7 @@ static int test__group_gh3(struct evlist *evlist)
> >> TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest);
> >> TEST_ASSERT_VAL("wrong exclude host", evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel));
> >> TEST_ASSERT_VAL("wrong core.nr_members", evsel->core.nr_members == 2);
> >> TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) == 0);
> >> @@ -1121,7 +1121,7 @@ static int test__group_gh4(struct evlist *evlist)
> >> TEST_ASSERT_VAL("wrong exclude guest", !evsel->core.attr.exclude_guest);
> >> TEST_ASSERT_VAL("wrong exclude host", evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__is_group_leader(evsel));
> >> TEST_ASSERT_VAL("wrong core.nr_members", evsel->core.nr_members == 2);
> >> TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) == 0);
> >> @@ -1160,7 +1160,7 @@ static int test__leader_sample1(struct evlist *evlist)
> >> TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest);
> >> TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__has_leader(evsel, leader));
> >> TEST_ASSERT_VAL("wrong sample_read", evsel->core.sample_read);
> >>
> >> @@ -1189,7 +1189,7 @@ static int test__leader_sample1(struct evlist *evlist)
> >> TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest);
> >> TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__has_leader(evsel, leader));
> >> TEST_ASSERT_VAL("wrong sample_read", evsel->core.sample_read);
> >>
> >> @@ -1213,7 +1213,7 @@ static int test__leader_sample2(struct evlist *evlist __maybe_unused)
> >> TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest);
> >> TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__has_leader(evsel, leader));
> >> TEST_ASSERT_VAL("wrong sample_read", evsel->core.sample_read);
> >>
> >> @@ -1228,7 +1228,7 @@ static int test__leader_sample2(struct evlist *evlist __maybe_unused)
> >> TEST_ASSERT_VAL("wrong exclude guest", evsel->core.attr.exclude_guest);
> >> TEST_ASSERT_VAL("wrong exclude host", !evsel->core.attr.exclude_host);
> >> TEST_ASSERT_VAL("wrong precise_ip", !evsel->core.attr.precise_ip);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__has_leader(evsel, leader));
> >> TEST_ASSERT_VAL("wrong sample_read", evsel->core.sample_read);
> >>
> >> @@ -1259,7 +1259,7 @@ static int test__pinned_group(struct evlist *evlist)
> >> TEST_ASSERT_VAL("wrong type", PERF_TYPE_HARDWARE == evsel->core.attr.type);
> >> TEST_ASSERT_VAL("wrong config",
> >> PERF_COUNT_HW_CPU_CYCLES == evsel->core.attr.config);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__has_leader(evsel, leader));
> >> TEST_ASSERT_VAL("wrong pinned", evsel->core.attr.pinned);
> >>
> >> @@ -1303,7 +1303,7 @@ static int test__exclusive_group(struct evlist *evlist)
> >> TEST_ASSERT_VAL("wrong type", PERF_TYPE_HARDWARE == evsel->core.attr.type);
> >> TEST_ASSERT_VAL("wrong config",
> >> PERF_COUNT_HW_CPU_CYCLES == evsel->core.attr.config);
> >> - TEST_ASSERT_VAL("wrong group name", !evsel->group_name);
> >> + TEST_ASSERT_VAL("wrong group name", !evsel->core.group_name);
> >> TEST_ASSERT_VAL("wrong leader", evsel__has_leader(evsel, leader));
> >> TEST_ASSERT_VAL("wrong exclusive", evsel->core.attr.exclusive);
> >>
> >> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> >> index c679394b898d..a882bc81e0fb 100644
> >> --- a/tools/perf/util/auxtrace.c
> >> +++ b/tools/perf/util/auxtrace.c
> >> @@ -1235,9 +1235,9 @@ static void unleader_evsel(struct evlist *evlist, struct evsel *leader)
> >>
> >> /* Update group information */
> >> if (new_leader) {
> >> - zfree(&new_leader->group_name);
> >> - new_leader->group_name = leader->group_name;
> >> - leader->group_name = NULL;
> >> + zfree(&new_leader->core.group_name);
> >> + new_leader->core.group_name = leader->core.group_name;
> >> + leader->core.group_name = NULL;
> >>
> >> new_leader->core.nr_members = leader->core.nr_members - 1;
> >> leader->core.nr_members = 1;
> >> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> >> index aafd91805870..7621eddc8e58 100644
> >> --- a/tools/perf/util/evsel.c
> >> +++ b/tools/perf/util/evsel.c
> >> @@ -395,9 +395,9 @@ struct evsel *evsel__clone(struct evsel *orig)
> >> if (evsel->core.name == NULL)
> >> goto out_err;
> >> }
> >> - if (orig->group_name) {
> >> - evsel->group_name = strdup(orig->group_name);
> >> - if (evsel->group_name == NULL)
> >> + if (orig->core.group_name) {
> >> + evsel->core.group_name = strdup(orig->core.group_name);
> >> + if (evsel->core.group_name == NULL)
> >> goto out_err;
> >> }
> >> if (orig->pmu_name) {
> >> @@ -797,7 +797,7 @@ const char *evsel__metric_id(const struct evsel *evsel)
> >>
> >> const char *evsel__group_name(struct evsel *evsel)
> >> {
> >> - return evsel->group_name ?: "anon group";
> >> + return evsel->core.group_name ?: "anon group";
> >> }
> >>
> >> /*
> >> @@ -1436,7 +1436,7 @@ void evsel__exit(struct evsel *evsel)
> >> perf_cpu_map__put(evsel->core.cpus);
> >> perf_cpu_map__put(evsel->core.own_cpus);
> >> perf_thread_map__put(evsel->core.threads);
> >> - zfree(&evsel->group_name);
> >> + zfree(&evsel->core.group_name);
> >> zfree(&evsel->core.name);
> >> zfree(&evsel->pmu_name);
> >> zfree(&evsel->core.metric_id);
> >> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> >> index c09bbddd5da0..e06d171baba3 100644
> >> --- a/tools/perf/util/evsel.h
> >> +++ b/tools/perf/util/evsel.h
> >> @@ -54,7 +54,6 @@ struct evsel {
> >> * they can be released properly.
> >> */
> >> struct {
> >> - char *group_name;
> >> const char *pmu_name;
> >> struct tep_event *tp_format;
> >> char *filter;
> >> diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c
> >> index 8c2ea8001329..4670d1e745b2 100644
> >> --- a/tools/perf/util/evsel_fprintf.c
> >> +++ b/tools/perf/util/evsel_fprintf.c
> >> @@ -48,7 +48,7 @@ int evsel__fprintf(struct evsel *evsel, struct perf_attr_details *details, FILE
> >> return 0;
> >>
> >> if (evsel->core.nr_members > 1)
> >> - printed += fprintf(fp, "%s{", evsel->group_name ?: "");
> >> + printed += fprintf(fp, "%s{", evsel->core.group_name ?: "");
> >>
> >> printed += fprintf(fp, "%s", evsel__name(evsel));
> >> for_each_group_member(pos, evsel)
> >> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> >> index 4610b23fed28..a14b690a6025 100644
> >> --- a/tools/perf/util/header.c
> >> +++ b/tools/perf/util/header.c
> >> @@ -788,7 +788,7 @@ static int write_group_desc(struct feat_fd *ff,
> >>
> >> evlist__for_each_entry(evlist, evsel) {
> >> if (evsel__is_group_leader(evsel) && evsel->core.nr_members > 1) {
> >> - const char *name = evsel->group_name ?: "{anon_group}";
> >> + const char *name = evsel->core.group_name ?: "{anon_group}";
> >> u32 leader_idx = evsel->core.idx;
> >> u32 nr_members = evsel->core.nr_members;
> >>
> >> @@ -2094,7 +2094,7 @@ static void print_group_desc(struct feat_fd *ff, FILE *fp)
> >>
> >> evlist__for_each_entry(session->evlist, evsel) {
> >> if (evsel__is_group_leader(evsel) && evsel->core.nr_members > 1) {
> >> - fprintf(fp, "# group: %s{%s", evsel->group_name ?: "", evsel__name(evsel));
> >> + fprintf(fp, "# group: %s{%s", evsel->core.group_name ?: "", evsel__name(evsel));
> >>
> >> nr = evsel->core.nr_members - 1;
> >> } else if (nr) {
> >> @@ -2743,7 +2743,7 @@ static int process_group_desc(struct feat_fd *ff, void *data __maybe_unused)
> >> evsel__set_leader(evsel, evsel);
> >> /* {anon_group} is a dummy name */
> >> if (strcmp(desc[i].name, "{anon_group}")) {
> >> - evsel->group_name = desc[i].name;
> >> + evsel->core.group_name = desc[i].name;
> >> desc[i].name = NULL;
> >> }
> >> evsel->core.nr_members = desc[i].nr_members;
> >> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> >> index 24d01b768078..05a96b0f7b41 100644
> >> --- a/tools/perf/util/parse-events.c
> >> +++ b/tools/perf/util/parse-events.c
> >> @@ -1841,7 +1841,7 @@ parse_events__set_leader_for_uncore_aliase(char *name, struct list_head *list,
> >> for (i = 0; i < nr_pmu; i++) {
> >> evsel = (struct evsel *) leaders[i];
> >> evsel->core.nr_members = total_members / nr_pmu;
> >> - evsel->group_name = name ? strdup(name) : NULL;
> >> + evsel->core.group_name = name ? strdup(name) : NULL;
> >> }
> >>
> >> /* Take the new small groups into account */
> >> @@ -1869,7 +1869,7 @@ void parse_events__set_leader(char *name, struct list_head *list,
> >>
> >> __perf_evlist__set_leader(list);
> >> leader = list_entry(list->next, struct evsel, core.node);
> >> - leader->group_name = name ? strdup(name) : NULL;
> >> + leader->core.group_name = name ? strdup(name) : NULL;
> >> }
> >>
> >> /* list_event is assumed to point to malloc'ed memory */
> >> --
> >> 2.31.1
> >>
>
next prev parent reply other threads:[~2021-11-08 21:19 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 13:36 [RFC 00/59] libperf: Move in event parse code Jiri Olsa
2021-11-08 13:36 ` [PATCH 01/59] libperf: Move pmu-events.h file to libperf Jiri Olsa
2021-11-08 13:36 ` [PATCH 03/59] libperf: Move pmu-events build " Jiri Olsa
2021-11-08 13:36 ` [PATCH 04/59] libperf: Move perf_pmu__format_parse " Jiri Olsa
2021-11-08 13:36 ` [PATCH 05/59] tools api fs: Move in the fncache from perf Jiri Olsa
2021-11-08 17:46 ` Ian Rogers
2021-11-08 21:15 ` Jiri Olsa
2021-11-08 13:36 ` [PATCH 06/59] libperf: Move in the pmu hybrid support Jiri Olsa
2021-11-08 13:36 ` [PATCH 07/59] libperf: Move name to perf_evsel Jiri Olsa
2021-11-08 13:36 ` [PATCH 08/59] libperf: Move auto_merge_stats " Jiri Olsa
2021-11-08 13:36 ` [PATCH 09/59] libperf: Move config_terms " Jiri Olsa
2021-11-08 13:36 ` [PATCH 10/59] libperf: Move metric_id " Jiri Olsa
2021-11-08 13:36 ` [PATCH 11/59] libperf: Move tool_event " Jiri Olsa
2021-11-08 13:36 ` [PATCH 12/59] libperf: Move unit " Jiri Olsa
2021-11-08 13:36 ` [PATCH 13/59] libperf: Move exclude_GH " Jiri Olsa
2021-11-08 17:53 ` Ian Rogers
2021-11-08 21:16 ` Jiri Olsa
2021-11-08 13:36 ` [PATCH 14/59] libperf: Move sample_read " Jiri Olsa
2021-11-08 13:36 ` [PATCH 15/59] libperf: Move precise_max " Jiri Olsa
2021-11-08 13:36 ` [PATCH 16/59] libperf: Move weak_group " Jiri Olsa
2021-11-08 13:36 ` [PATCH 17/59] libperf: Move bpf_counter " Jiri Olsa
2021-11-08 13:36 ` [PATCH 18/59] libperf: Move group_name " Jiri Olsa
2021-11-08 17:58 ` Ian Rogers
2021-11-08 18:07 ` Arnaldo Carvalho de Melo
2021-11-08 21:19 ` Jiri Olsa [this message]
2021-11-08 13:36 ` [PATCH 19/59] perf tools: Fix parse_events_term__num call Jiri Olsa
2021-11-08 18:15 ` Ian Rogers
2021-11-08 21:21 ` Jiri Olsa
2021-11-08 13:36 ` [PATCH 20/59] perf tools: Pass parse_state all the way down to __add_event Jiri Olsa
2021-11-08 13:36 ` [PATCH 21/59] perf tools: Pass parse_state all the way down to add_tracepoint Jiri Olsa
2021-11-08 13:36 ` [PATCH 22/59] perf tools: Add evsel__new callback to parse_state_ops Jiri Olsa
2021-11-08 13:36 ` [PATCH 23/59] perf tools: Add evsel__new_tp " Jiri Olsa
2021-11-08 13:36 ` [PATCH 24/59] perf tools: Add loc_term and loc_val helpers to parse_events_term__str Jiri Olsa
2021-11-08 13:36 ` [PATCH 25/59] perf tools: Add loc_term and loc_val helpers to parse_events_term__num Jiri Olsa
2021-11-08 13:36 ` [PATCH 26/59] libperf: Move in the event_symbols_hw/event_symbols_sw Jiri Olsa
2021-11-08 13:36 ` [PATCH 27/59] libperf: Move in struct parse_events_term code Jiri Olsa
2021-11-08 13:36 ` [PATCH 28/59] perf tools: Add perf_evsel__add_event function Jiri Olsa
2021-11-08 13:36 ` [PATCH 29/59] perf tools: Change struct parse_events_state::evlist to perf_evlist Jiri Olsa
2021-11-08 13:36 ` [PATCH 30/59] libperf: Move in struct parse_events_state Jiri Olsa
2021-11-08 18:21 ` Ian Rogers
2021-11-08 21:24 ` Jiri Olsa
2021-11-08 13:36 ` [PATCH 31/59] perf tools: Move event_attr_init in evsel__new_idx function Jiri Olsa
2021-11-08 13:36 ` [PATCH 32/59] libperf: Move in perf_pmu__warn_invalid_config function Jiri Olsa
2021-11-08 13:36 ` [PATCH 33/59] libperf: Move in perf_evsel__add_event function Jiri Olsa
2021-11-08 13:36 ` [PATCH 34/59] perf tools: Move parse_events_update_lists to parser unit Jiri Olsa
2021-11-08 13:36 ` [PATCH 35/59] libperf: Add perf_evsel__is_group_leader function Jiri Olsa
2021-11-08 13:36 ` [PATCH 36/59] perf tools: Make parse_events__modifier_event work over perf_evsel Jiri Olsa
2021-11-08 13:36 ` [PATCH 37/59] perf tool: Pass perf_guest in struct parse_events_state Jiri Olsa
2021-11-08 13:36 ` [PATCH 38/59] libperf: Move in parse_events__modifier_group/event functions Jiri Olsa
2021-11-08 13:36 ` [PATCH 39/59] libperf: Move in parse_events__handle_error function Jiri Olsa
2021-11-08 13:36 ` [PATCH 40/59] libperf: Move in parse_events_evlist_error function Jiri Olsa
2021-11-08 13:36 ` [PATCH 41/59] perf tools: Add perf_evsel__delete callback to struct parse_events_ops Jiri Olsa
2021-11-08 13:36 ` [PATCH 42/59] libperf: Move in parse_events_name function Jiri Olsa
2021-11-08 18:23 ` Ian Rogers
2021-11-08 21:24 ` Jiri Olsa
2021-11-08 13:36 ` [PATCH 43/59] perf tools: Move out parse_events_add_pmu fallback from parser code Jiri Olsa
2021-11-08 13:36 ` [PATCH 44/59] perf tools: Add add_pmu callback to struct parse_events_ops Jiri Olsa
2021-11-08 13:36 ` [PATCH 45/59] perf tools: Add add_pmu_multi " Jiri Olsa
2021-11-08 13:36 ` [PATCH 46/59] perf tools: Add add_numeric " Jiri Olsa
2021-11-08 18:27 ` Ian Rogers
2021-11-08 21:34 ` Jiri Olsa
2021-11-08 13:36 ` [PATCH 47/59] perf tools: Add add_cache " Jiri Olsa
2021-11-08 13:36 ` [PATCH 48/59] perf tools: Add add_breakpoint " Jiri Olsa
2021-11-08 13:37 ` [PATCH 49/59] perf tools: Add add_tracepoint " Jiri Olsa
2021-11-08 13:37 ` [PATCH 50/59] perf tools: Add add_bpf " Jiri Olsa
2021-11-08 13:37 ` [PATCH 51/59] perf tools: Add add_tool " Jiri Olsa
2021-11-08 13:37 ` [PATCH 52/59] perf tools: Add set_leader " Jiri Olsa
2021-11-08 13:37 ` [PATCH 53/59] perf tools: Add parse_check " Jiri Olsa
2021-11-08 13:37 ` [PATCH 54/59] perf tools: Move PE_* enums in parse_events__scanner Jiri Olsa
2021-11-08 13:37 ` [PATCH 55/59] libperf: Move in parse-events flex/bison parser Jiri Olsa
2021-11-08 13:37 ` [PATCH 56/59] libperf: Move in parse_events_add_breakpoint function Jiri Olsa
2021-11-08 13:37 ` [PATCH 57/59] libperf: Move in some lib objects from perf Jiri Olsa
2021-11-08 13:37 ` [PATCH 58/59] libperf: Add libperf_parse_events function Jiri Olsa
2021-11-08 13:37 ` [PATCH 59/59] libperf: Add parse-events test Jiri Olsa
2021-11-08 18:32 ` Ian Rogers
2021-11-08 21:37 ` Jiri Olsa
2021-11-08 18:50 ` [RFC 00/59] libperf: Move in event parse code Ian Rogers
2021-11-08 21:50 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYmUbGz8ZOSnldyy@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).