[PATCH] perf/test: Test case 27 broken on s390 in linux-next

[PATCH] perf/test: Test case 27 broken on s390 in linux-next

[Thomas Richter]

Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
broke the test case 27 (Sample parsing) on s390 on linux-next tree:

  # ./perf test -Fv 27
  27: Sample parsing
  --- start ---
  parsing failed for sample_type 0x800
  ---- end ----
  Sample parsing: FAILED!
  #

The cause of the failure is a wrong #define BS_EXPECTED_BE statement
in above commit.  Correct this define and the test case runs fine.

Output After:
  # ./perf test -Fv 27
  27: Sample parsing                                                  :
  --- start ---
  ---- end ----
  Sample parsing: Ok
  #

Fixes: 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
---
 tools/perf/tests/sample-parsing.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/sample-parsing.c b/tools/perf/tests/sample-parsing.c
index c83a11514129..9c7af55b74db 100644
--- a/tools/perf/tests/sample-parsing.c
+++ b/tools/perf/tests/sample-parsing.c
@@ -36,7 +36,7 @@
  * These are based on the input value (213) specified
  * in branch_stack variable.
  */
-#define BS_EXPECTED_BE	0xa00d000000000000
+#define BS_EXPECTED_BE	0xa000d00000000000
 #define BS_EXPECTED_LE	0xd5000000
 #define FLAG(s)	s->branch_stack->entries[i].flags
 
-- 
2.25.1

Re: [PATCH] perf/test: Test case 27 broken on s390 in linux-next

[Arnaldo Carvalho de Melo]

Em Wed, Nov 03, 2021 at 04:52:15PM +0100, Thomas Richter escreveu:
> Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
> broke the test case 27 (Sample parsing) on s390 on linux-next tree:

Maddy,

	Can you please ack this one?

- Arnaldo
 
>   # ./perf test -Fv 27
>   27: Sample parsing
>   --- start ---
>   parsing failed for sample_type 0x800
>   ---- end ----
>   Sample parsing: FAILED!
>   #
> 
> The cause of the failure is a wrong #define BS_EXPECTED_BE statement
> in above commit.  Correct this define and the test case runs fine.
> 
> Output After:
>   # ./perf test -Fv 27
>   27: Sample parsing                                                  :
>   --- start ---
>   ---- end ----
>   Sample parsing: Ok
>   #
> 
> Fixes: 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> ---
>  tools/perf/tests/sample-parsing.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/sample-parsing.c b/tools/perf/tests/sample-parsing.c
> index c83a11514129..9c7af55b74db 100644
> --- a/tools/perf/tests/sample-parsing.c
> +++ b/tools/perf/tests/sample-parsing.c
> @@ -36,7 +36,7 @@
>   * These are based on the input value (213) specified
>   * in branch_stack variable.
>   */
> -#define BS_EXPECTED_BE	0xa00d000000000000
> +#define BS_EXPECTED_BE	0xa000d00000000000
>  #define BS_EXPECTED_LE	0xd5000000
>  #define FLAG(s)	s->branch_stack->entries[i].flags
>  
> -- 
> 2.25.1

-- 

- Arnaldo

PING [PATCH] perf/test: Test case 27 broken on s390 in linux-next

[Thomas Richter]

Hi Arnaldo, 

since I have not received any ACK from Maddy and the issue still shows up on s390 in
our daily test suite, can you go ahead and pick this patch.

Thanks 

Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294



-------- Forwarded Message --------
Subject: [PATCH] perf/test: Test case 27 broken on s390 in linux-next
Date: Wed,  3 Nov 2021 16:52:15 +0100
From: Thomas Richter <tmricht@linux.ibm.com>
To: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, sumanthk@linux.ibm.com, maddy@linux.ibm.com, jolsa@redhat.com
CC: svens@linux.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com, Thomas Richter <tmricht@linux.ibm.com>

Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
broke the test case 27 (Sample parsing) on s390 on linux-next tree:

  # ./perf test -Fv 27
  27: Sample parsing
  --- start ---
  parsing failed for sample_type 0x800
  ---- end ----
  Sample parsing: FAILED!
  #

The cause of the failure is a wrong #define BS_EXPECTED_BE statement
in above commit.  Correct this define and the test case runs fine.

Output After:
  # ./perf test -Fv 27
  27: Sample parsing                                                  :
  --- start ---
  ---- end ----
  Sample parsing: Ok
  #

Fixes: 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
---
 tools/perf/tests/sample-parsing.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/sample-parsing.c b/tools/perf/tests/sample-parsing.c
index c83a11514129..9c7af55b74db 100644
--- a/tools/perf/tests/sample-parsing.c
+++ b/tools/perf/tests/sample-parsing.c
@@ -36,7 +36,7 @@
  * These are based on the input value (213) specified
  * in branch_stack variable.
  */
-#define BS_EXPECTED_BE	0xa00d000000000000
+#define BS_EXPECTED_BE	0xa000d00000000000
 #define BS_EXPECTED_LE	0xd5000000
 #define FLAG(s)	s->branch_stack->entries[i].flags
 
-- 
2.25.1


-- 
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294

Re: [PATCH] perf/test: Test case 27 broken on s390 in linux-next

[Madhavan Srinivasan]

On 11/7/21 01:02, Arnaldo Carvalho de Melo wrote:
> Em Wed, Nov 03, 2021 at 04:52:15PM +0100, Thomas Richter escreveu:
>> Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
>> broke the test case 27 (Sample parsing) on s390 on linux-next tree:
> Maddy,
>
> 	Can you please ack this one?

Sorry i missed this completely. My bad. Will check it and will reply.

Maddy


>
> - Arnaldo
>   
>>    # ./perf test -Fv 27
>>    27: Sample parsing
>>    --- start ---
>>    parsing failed for sample_type 0x800
>>    ---- end ----
>>    Sample parsing: FAILED!
>>    #
>>
>> The cause of the failure is a wrong #define BS_EXPECTED_BE statement
>> in above commit.  Correct this define and the test case runs fine.
>>
>> Output After:
>>    # ./perf test -Fv 27
>>    27: Sample parsing                                                  :
>>    --- start ---
>>    ---- end ----
>>    Sample parsing: Ok
>>    #
>>
>> Fixes: 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
>> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
>> ---
>>   tools/perf/tests/sample-parsing.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/tests/sample-parsing.c b/tools/perf/tests/sample-parsing.c
>> index c83a11514129..9c7af55b74db 100644
>> --- a/tools/perf/tests/sample-parsing.c
>> +++ b/tools/perf/tests/sample-parsing.c
>> @@ -36,7 +36,7 @@
>>    * These are based on the input value (213) specified
>>    * in branch_stack variable.
>>    */
>> -#define BS_EXPECTED_BE	0xa00d000000000000
>> +#define BS_EXPECTED_BE	0xa000d00000000000
>>   #define BS_EXPECTED_LE	0xd5000000
>>   #define FLAG(s)	s->branch_stack->entries[i].flags
>>   
>> -- 
>> 2.25.1

Re: [PATCH] perf/test: Test case 27 broken on s390 in linux-next

[Madhavan Srinivasan]

On 11/3/21 21:22, Thomas Richter wrote:
> Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
> broke the test case 27 (Sample parsing) on s390 on linux-next tree:
>
>    # ./perf test -Fv 27
>    27: Sample parsing
>    --- start ---
>    parsing failed for sample_type 0x800
>    ---- end ----
>    Sample parsing: FAILED!
>    #
>
> The cause of the failure is a wrong #define BS_EXPECTED_BE statement
> in above commit.  Correct this define and the test case runs fine.
>
> Output After:
>    # ./perf test -Fv 27
>    27: Sample parsing                                                  :
>    --- start ---
>    ---- end ----
>    Sample parsing: Ok
>    #


Hi Thomas,
Thanks for the fix. Not sure, I guess I messed up my big endian setup or 
test run I had before sending
the patch. My bad. It fails for me too, but with your patch the issue 
fixed.

Acked-and-Tested-by: Madhavan Srinivasan <maddy@linux.ibm.com>


>
> Fixes: 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> ---
>   tools/perf/tests/sample-parsing.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/sample-parsing.c b/tools/perf/tests/sample-parsing.c
> index c83a11514129..9c7af55b74db 100644
> --- a/tools/perf/tests/sample-parsing.c
> +++ b/tools/perf/tests/sample-parsing.c
> @@ -36,7 +36,7 @@
>    * These are based on the input value (213) specified
>    * in branch_stack variable.
>    */
> -#define BS_EXPECTED_BE	0xa00d000000000000
> +#define BS_EXPECTED_BE	0xa000d00000000000
>   #define BS_EXPECTED_LE	0xd5000000
>   #define FLAG(s)	s->branch_stack->entries[i].flags
>   

Re: [PATCH] perf/test: Test case 27 broken on s390 in linux-next

[Arnaldo Carvalho de Melo]

Em Wed, Nov 17, 2021 at 02:35:29PM +0530, Madhavan Srinivasan escreveu:
> 
> On 11/3/21 21:22, Thomas Richter wrote:
> > Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
> > broke the test case 27 (Sample parsing) on s390 on linux-next tree:
> > 
> >    # ./perf test -Fv 27
> >    27: Sample parsing
> >    --- start ---
> >    parsing failed for sample_type 0x800
> >    ---- end ----
> >    Sample parsing: FAILED!
> >    #
> > 
> > The cause of the failure is a wrong #define BS_EXPECTED_BE statement
> > in above commit.  Correct this define and the test case runs fine.
> > 
> > Output After:
> >    # ./perf test -Fv 27
> >    27: Sample parsing                                                  :
> >    --- start ---
> >    ---- end ----
> >    Sample parsing: Ok
> >    #
> 
> 
> Hi Thomas,
> Thanks for the fix. Not sure, I guess I messed up my big endian setup or
> test run I had before sending
> the patch. My bad. It fails for me too, but with your patch the issue fixed.
> 
> Acked-and-Tested-by: Madhavan Srinivasan <maddy@linux.ibm.com>

Thanks, applied.

- Arnaldo