From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9401C433EF for ; Sun, 28 Nov 2021 16:31:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344278AbhK1Qev (ORCPT ); Sun, 28 Nov 2021 11:34:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23141 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358289AbhK1Qcu (ORCPT ); Sun, 28 Nov 2021 11:32:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638116974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vZW4/JuATNmbqT39WM6Wldifr5uJSWbgQDWe+YfFz5w=; b=DIjZUd96utj8x9pzVj226jPF0ADSfPhuL7GjZFWtBXZvJbU2SpI6tvHILDwIDYQL5SqWtf qLRp2JqsgGs87SFJknMiVeL75WiPNiJMOBP8yHq1cMm7UqtrZaKCvjbamOV3aj85L5bwvn Gb2Tg+S7l8Pxb/6oQzLSNf1UyurcUlM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-52-mOZ6WwEgPICHNpwlBBX07A-1; Sun, 28 Nov 2021 11:29:33 -0500 X-MC-Unique: mOZ6WwEgPICHNpwlBBX07A-1 Received: by mail-wm1-f71.google.com with SMTP id a85-20020a1c7f58000000b0033ddc0eacc8so8615307wmd.9 for ; Sun, 28 Nov 2021 08:29:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vZW4/JuATNmbqT39WM6Wldifr5uJSWbgQDWe+YfFz5w=; b=SMP8AOZAmIld86TR3P8H2HuBS+gmNE5TLl0vEDOQKVKHASPkCMMXUyaCx4Y3TCnhF5 p8xIDKRr0kN7c03DcvKFt4XsRi7wOsRUpv3JTEsCjYW+NhoQbhs6gBASDaRGZjQXM7Tp HLNRyfLn+DLxy4gVFApfSAy9reZTFmWK15wcc0xYJ9bO5lKiY8AVA98IF+PMI+I9Y4cb Zn5S5EJKWqszZU6RbWyQlG/456rxy1IVpZ2fpPsz8sIOB13lvexbuKypTyWMMwapXuB2 SXROsOybWxau75q6wgAsLgKu5JiwfbY5iFFH3U68iF2jbmAZ1jgsvz08mQJeUkttOKsz MD0g== X-Gm-Message-State: AOAM530tFnqqiolT2OFMSCxf6Kcm3m1K2aUTBNcYR0eRNd4ncba88Zqq IhN3TFOdMIsNSl2OO78dai4SJKvjlC1IrS+OEdhI5YTu+vYiSDxh5mMX4nOXmixcQxdXCOUgXHo V4R2Jkm/gBgyD2b6ukOr77NsPUwgc6g== X-Received: by 2002:a05:600c:34c2:: with SMTP id d2mr31197755wmq.102.1638116971747; Sun, 28 Nov 2021 08:29:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRc/Z3kDamUWfpAby3d8t9ZRNczcVQJkH5WO/uB63rEhSVcY5GG5mAxuBcGDc1Sdf0fdN8Zg== X-Received: by 2002:a05:600c:34c2:: with SMTP id d2mr31197734wmq.102.1638116971552; Sun, 28 Nov 2021 08:29:31 -0800 (PST) Received: from krava (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id l8sm18321556wmc.40.2021.11.28.08.29.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 08:29:31 -0800 (PST) Date: Sun, 28 Nov 2021 17:29:29 +0100 From: Jiri Olsa To: Ian Rogers Cc: Andi Kleen , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Arnaldo Carvalho de Melo , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, eranian@google.com Subject: Re: [PATCH] perf test: Reset shadow counts before loading Message-ID: References: <20211128085810.4027314-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211128085810.4027314-1-irogers@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Sun, Nov 28, 2021 at 12:58:10AM -0800, Ian Rogers wrote: > Otherwise load counting is an average. Without this change > duration_time in test_memory_bandwidth will alter its value if an > earlier test contains duration_time. > > This patch fixes an issue that's introduced in the proposed patch: > https://lore.kernel.org/lkml/20211124015226.3317994-1-irogers@google.com/ > in perf test "Parse and process metrics". > > Signed-off-by: Ian Rogers Acked-by: Jiri Olsa jirka > --- > tools/perf/tests/parse-metric.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/tests/parse-metric.c b/tools/perf/tests/parse-metric.c > index 574b7e4efd3a..07b6f4ec024f 100644 > --- a/tools/perf/tests/parse-metric.c > +++ b/tools/perf/tests/parse-metric.c > @@ -109,6 +109,7 @@ static void load_runtime_stat(struct runtime_stat *st, struct evlist *evlist, > struct evsel *evsel; > u64 count; > > + perf_stat__reset_shadow_stats(); > evlist__for_each_entry(evlist, evsel) { > count = find_value(evsel->name, vals); > perf_stat__update_shadow_stats(evsel, count, 0, st); > -- > 2.34.0.rc2.393.gf8c9666880-goog >