From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Gang Li <ligang.bdlg@bytedance.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf trace: Enable ignore_missing_thread for trace
Date: Tue, 30 Nov 2021 12:16:38 -0300 [thread overview]
Message-ID: <YaZAVjjPmAApJOG9@kernel.org> (raw)
In-Reply-To: <20211123074018.11406-1-ligang.bdlg@bytedance.com>
Em Tue, Nov 23, 2021 at 03:40:17PM +0800, Gang Li escreveu:
> perf already support ignore_missing_thread for -u/-p, but not yet
> applied to `perf trace`. This patch enable ignore_missing_thread
> for `perf trace`.
>
> ref:
> Link: http://lkml.kernel.org/r/1481538943-21874-6-git-send-email-jolsa@kernel.org
> Link: http://lkml.kernel.org/r/1513148513-6974-1-git-send-email-zhangmengting@huawei.com
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
> ---
> tools/perf/builtin-trace.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 0b52e08e558e..94d62a92f1a1 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -3950,6 +3950,9 @@ static int trace__run(struct trace *trace, int argc, const char **argv)
> evlist__add(evlist, pgfault_min);
> }
>
> + /* Enable ignoring missing threads when -u/-p option is defined. */
> + trace->opts.ignore_missing_thread = trace->opts.target.uid != UINT_MAX || trace->opts.target.pid;
> +
> if (trace->sched &&
> evlist__add_newtp(evlist, "sched", "sched_stat_runtime", trace__sched_stat_runtime))
> goto out_error_sched_stat_runtime;
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2021-11-30 15:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 7:40 [PATCH v1] perf trace: Enable ignore_missing_thread for trace Gang Li
2021-11-30 15:16 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaZAVjjPmAApJOG9@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).