From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Salvatore Bonaccorso <carnil@debian.org>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: German Gomez <german.gomez@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf dlfilter: Drop unused variable
Date: Thu, 9 Dec 2021 16:20:22 -0300 [thread overview]
Message-ID: <YbJW9sHObkXC5lcz@kernel.org> (raw)
In-Reply-To: <YbCS/xEis4QKbH6D@eldamar.lan>
Em Wed, Dec 08, 2021 at 12:11:59PM +0100, Salvatore Bonaccorso escreveu:
> Hi German,
>
> On Wed, Dec 08, 2021 at 10:44:01AM +0000, German Gomez wrote:
> >
> > On 23/11/2021 21:18, Salvatore Bonaccorso wrote:
> > > Compiling tools/perf/dlfilters/dlfilter-test-api-v0.c result in:
> > >
> > > checking for stdlib.h... dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’:
> > > dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable]
> > > 311 | struct filter_data *d = data;
> > > |
> >
> > Did you get this warning when issuing "make"? From my side, it generated
> > this gcc command so I didn't get it (make DEBUG=1):
> >
> > gcc -c -Iinclude -o dlfilters/dlfilter-test-api-v0.o -fpic dlfilters/dlfilter-test-api-v0.c
> >
> > Reviewed-by: German Gomez <german.gomez@arm.com>
>
> Only when passing -Wall (this is the case when building the kernel packages in
> Debian with additional flags, so this is why this was spotted):
>
> gcc -Wall -c -Iinclude -o dlfilters/dlfilter-test-api-v0.o -fpic dlfilters/dlfilter-test-api-v0.c
> dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’:
> dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable]
> 311 | struct filter_data *d = data;
> |
>
So I'm applying this, its an obvious cleanup, but please CC the author
next time, I'm doing it in this reply, Adrian, ok?
- Arnaldo
next prev parent reply other threads:[~2021-12-09 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 21:18 [PATCH] perf dlfilter: Drop unused variable Salvatore Bonaccorso
2021-12-08 10:44 ` German Gomez
2021-12-08 11:11 ` Salvatore Bonaccorso
2021-12-09 19:20 ` Arnaldo Carvalho de Melo [this message]
2021-12-09 19:40 ` Adrian Hunter
2021-12-09 20:15 ` Salvatore Bonaccorso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbJW9sHObkXC5lcz@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=carnil@debian.org \
--cc=german.gomez@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).