From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Michael Petlan <mpetlan@redhat.com>,
Ian Rogers <irogers@google.com>,
linux-perf-users@vger.kernel.org,
"Frank Ch. Eigler" <fche@redhat.com>
Subject: Re: [RFC] perf record: Disable debuginfod by default
Date: Fri, 10 Dec 2021 13:24:40 +0100 [thread overview]
Message-ID: <YbNHCLi/OdMUfgI0@krava> (raw)
In-Reply-To: <20211210080425.GO16608@worktop.programming.kicks-ass.net>
On Fri, Dec 10, 2021 at 09:04:25AM +0100, Peter Zijlstra wrote:
> On Thu, Dec 09, 2021 at 09:04:25PM +0100, Jiri Olsa wrote:
> > hi,
> > after migrating to fedora 35 I found perf record hanging on exit
> > and it's because fedora 35 sets DEBUGINFOD_URLS that triggers
> > debuginfod query which might take long time to process.
> >
> > I discussed this briefly with Frank and I'm sending the change
> > to disable debuginfod by default in perf record.
> >
> > Frank had other idea we could discuss here to fork or just spawn
> > "/usr/bin/debuginfod-find ...." into background after perf record.
> >
> > Perhaps there are other ways as well, hence this is RFC ;-)
> >
> > thanks,
> > jirka
> >
> >
> > ---
> > Fedora 35 sets by default DEBUGINFOD_URLS, which might lead
> > to unexpected stalls in perf record exit path, when we try
> > to cache profiled binaries.
> >
> > # DEBUGINFOD_PROGRESS=1 ./perf record -a
> > ^C[ perf record: Woken up 1 times to write data ]
> > Downloading from https://debuginfod.fedoraproject.org/ 447069
> > Downloading from https://debuginfod.fedoraproject.org/ 1502175
> > Downloading \^Z
> >
> > Disabling DEBUGINFOD_URLS by default in perf record and adding
> > debuginfod option and .perfconfig variable support to enable id.
> >
> > Default without debuginfo processing:
> > # perf record -a
> >
> > Using system debuginfod setup:
> > # perf record -a --debuginfod
> >
> > Using custom debuginfd url:
> > # perf record -a --debuginfod='https://evenbetterdebuginfodserver.krava'
> >
> > Adding single perf_debuginfod_setup function and using
> > it also in perf buildid-cache command.
>
> I'm still running with --no-buildid --no-buildid-cache or something like
> that by default. As long as that remains working I'm good.
you're good ;-) that will bypass the problem completely
jirka
next prev parent reply other threads:[~2021-12-10 12:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 20:04 [RFC] perf record: Disable debuginfod by default Jiri Olsa
2021-12-09 23:39 ` Namhyung Kim
2021-12-10 12:23 ` Jiri Olsa
2021-12-10 16:50 ` Frank Ch. Eigler
2021-12-19 13:04 ` Jiri Olsa
2021-12-10 18:41 ` Namhyung Kim
2021-12-11 19:57 ` Jiri Olsa
2021-12-10 8:04 ` Peter Zijlstra
2021-12-10 12:24 ` Jiri Olsa [this message]
2021-12-10 13:33 ` Arnaldo Carvalho de Melo
2021-12-19 13:06 ` Jiri Olsa
2022-01-15 20:22 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbNHCLi/OdMUfgI0@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=fche@redhat.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).