From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alistair Francis <alistair.francis@opensource.wdc.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Darren Hart <dvhart@infradead.org>,
Alistair Francis <alistair23@gmail.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
linux-perf-users@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alistair Francis <alistair.francis@wdc.com>,
Atish Patra <atish.patra@wdc.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v5 1/6] perf bench futex: Add support for 32-bit systems with 64-bit time_t
Date: Sat, 11 Dec 2021 08:28:59 -0300 [thread overview]
Message-ID: <YbSLe1EWglAc592n@kernel.org> (raw)
In-Reply-To: <CAK8P3a05D=fb9stZEL6rUMs7c=S6gJxN5gR7HG_i8RiXAbaB5Q@mail.gmail.com>
Em Fri, Dec 10, 2021 at 03:23:42PM +0100, Arnd Bergmann escreveu:
> On Fri, Dec 10, 2021 at 2:44 PM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> > Em Fri, Dec 10, 2021 at 10:36:30AM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Dec 10, 2021 at 09:58:52AM +1000, Alistair Francis escreveu:
> > > > From: Alistair Francis <alistair.francis@wdc.com>
> > > > Some 32-bit architectures (such are 32-bit RISC-V) only have a 64-bit
> > > > time_t and as such don't have the SYS_futex syscall. This patch will
> > > > allow us to use the SYS_futex_time64 syscall on those platforms.
> > > > This also converts the futex calls to be y2038 safe (when built for a
> > > > 5.1+ kernel).
> > > > This is a revert of commit ba4026b09d83acf56c040b6933eac7916c27e728
> > > > "Revert "perf bench futex: Add support for 32-bit systems with 64-bit time_t"".
> > > > The original commit was reverted as including linux/time_types.h would
> > > > fail to compile on older kernels. This commit doesn't include
> > > > linux/time_types.h to avoid this issue.
> > > 10 9.99 alpine:3.12 : FAIL gcc version 9.3.0 (Alpine 9.3.0)
> > > In file included from bench/futex-hash.c:29:
> > > bench/futex.h:37:2: error: unknown type name '__kernel_old_time_t'
> > > 37 | __kernel_old_time_t tv_sec; /* seconds */
> > > | ^~~~~~~~~~~~~~~~~~~
> > > In file included from bench/futex-wake.c:25:
> It looks like we need to add include/uapi/linux/time_types.h to
> tools/include/linux/ and update tools/include/linux/types.h
> in order to address this.
And make sure it is found before the system ones, yes, that would fix
the issues. I'll try to do it these days.
- Arnaldo
next prev parent reply other threads:[~2021-12-11 11:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 23:58 [PATCH v5 1/6] perf bench futex: Add support for 32-bit systems with 64-bit time_t Alistair Francis
2021-12-09 23:58 ` [PATCH v5 2/6] selftests: futex: Call the futex syscall from a function Alistair Francis
2021-12-09 23:58 ` [PATCH v5 3/6] uapi: futex: Add a futex syscall Alistair Francis
2021-12-09 23:58 ` [PATCH v5 4/6] selftests: futex: Add support for 32-bit systems with 64-bit time_t Alistair Francis
2021-12-09 23:58 ` [PATCH v5 5/6] uapi: futex: Add a futex waitv syscall Alistair Francis
2021-12-09 23:58 ` [PATCH v5 6/6] selftests: futex: Use futex_waitv helper function Alistair Francis
2021-12-10 13:12 ` [PATCH v5 1/6] perf bench futex: Add support for 32-bit systems with 64-bit time_t Arnaldo Carvalho de Melo
2021-12-10 13:36 ` Arnaldo Carvalho de Melo
2021-12-10 13:44 ` Arnaldo Carvalho de Melo
2021-12-10 14:23 ` Arnd Bergmann
2021-12-11 11:28 ` Arnaldo Carvalho de Melo [this message]
2022-02-01 5:37 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbSLe1EWglAc592n@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alistair.francis@opensource.wdc.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=atish.patra@wdc.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).