From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: Fix perf-record manual typo
Date: Thu, 23 Dec 2021 23:03:56 -0300 [thread overview]
Message-ID: <YcUqjPeawdnH2JeV@kernel.org> (raw)
In-Reply-To: <OFF9778928.59F62D85-ON002587B3.00757F55-882587B3.00766874@ibm.com>
Em Wed, Dec 22, 2021 at 02:33:20PM -0700, Kevin Grigorenko escreveu:
> From: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
> Date: Wed, 22 Dec 2021 13:21:44 -0800
> Subject: [PATCH] perf: Fix perf-record manual typo
>
> Signed-off-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
> ---
> tools/perf/Documentation/perf-record.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/perf-record.txt
> b/tools/perf/Documentation/perf-record.txt
> index 3cf7bac67239..52f98d53a97e 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -258,7 +258,7 @@ OPTIONS
> Call Frame Information) or "lbr" (Hardware Last Branch Record
> facility).
>
> - In some systems, where binaries are build with gcc
> + In some systems, where binaries are built with gcc
> --fomit-frame-pointer, using the "fp" method will produce bogus
> call graphs, using "dwarf", if available (perf tools linked to
> the libunwind or libdw library) should be used instead.
Can you please check this works with what is in acme/perf/core?
⬢[acme@toolbox perf]$ git checkout perf/core
Switched to branch 'perf/core'
⬢[acme@toolbox perf]$ am
Applying: perf: Fix perf-record manual typo
error: git diff header lacks filename information when removing 1 leading pathname component (line 6)
Patch failed at 0001 perf: Fix perf-record manual typo
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
⬢[acme@toolbox perf]$ git am --abort
⬢[acme@toolbox perf]$ git diff
⬢[acme@toolbox perf]$ patch -p1 < ~/wb/1.patch
patching file tools/perf/Documentation/perf-record.txt
Hunk #1 FAILED at 258.
1 out of 1 hunk FAILED -- saving rejects to file tools/perf/Documentation/perf-record.txt.rej
⬢[acme@toolbox perf]$
prev parent reply other threads:[~2021-12-24 2:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 21:33 [PATCH] perf: Fix perf-record manual typo Kevin Grigorenko
2021-12-23 17:47 ` Ian Rogers
2021-12-24 2:03 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcUqjPeawdnH2JeV@kernel.org \
--to=acme@kernel.org \
--cc=kevin.grigorenko@us.ibm.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).