From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF43C433EF for ; Wed, 12 Jan 2022 17:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344144AbiALRxs (ORCPT ); Wed, 12 Jan 2022 12:53:48 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:46002 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344090AbiALRxp (ORCPT ); Wed, 12 Jan 2022 12:53:45 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E95DB61965; Wed, 12 Jan 2022 17:53:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32C53C36AEA; Wed, 12 Jan 2022 17:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642010024; bh=bB0F4ynqROi7/Nr6NboWLFBR9m4kGwynIwBytKGuibA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xcp1KJyUyKpOaR0EnEg27qifBO5NUx4sVS7z+cPHJpAli/a9twmHfHmikJAhalU5M Av+GWOq2/I4LjMueagmuxDE3lGJ/n5QTigrg941YTPwvF9i6xGnt1NauZGuydwYbn2 UwoiUccAcky8LJ+k1a0kwH6WFW33UAlH5gIK1VlmJv/8ASX0uzik13NvgvFRTqIVG7 5dW1o2KXwLu7bCePRZSIrsU6cIxKnL64iuh0KeqQtIlKc2CjQXRyEcPfZ9u42fVGi4 dlFDFYZctOM+0aADSFl3QdFUCJ8PYj/piJJqmrPt22OUzw4hPaQfbeeE2iPfGneYKZ jaHC9kSaV0YbA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 5BBD440714; Wed, 12 Jan 2022 14:53:42 -0300 (-03) Date: Wed, 12 Jan 2022 14:53:42 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Andi Kleen , Jiri Olsa , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, eranian@google.com Subject: Re: [RFC PATCH] perf pmu-events: Don't lower case MetricExpr Message-ID: References: <20211126071305.3733878-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Wed, Jan 12, 2022 at 02:45:07PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Jan 12, 2022 at 09:22:51AM -0800, Ian Rogers escreveu: > > On Thu, Nov 25, 2021 at 11:13 PM Ian Rogers wrote: > > > > > > This patch changes MetricExpr to be written out in the same case. This > > > enables events in metrics to use modifiers like 'G' which currently > > > yield parse errors when made lower case. To keep tests passing the > > > literal #smt_on is compared in a non-case sensitive way - #SMT_on is > > > present in at least SkylakeX metrics. > > > > Ping. > > I tried applying 20211124001231.3277836-1-irogers@google.com on top of > your perf_cpu series, it failed, will check. > > BTW, I got the two other patches in that series: > > ⬢[acme@toolbox perf]$ git log --oneline -2 > 6dd8646939a770e4 (HEAD -> perf/core) perf tools: Probe non-deprecated sysfs path 1st > 0ce05781f4905fcf perf tools: Fix SMT fallback with large core counts > ⬢[acme@toolbox perf]$ Ok, I have that one now on, but could Andi or somebody else that works more frequently with that code provide an Acked-by or Reviewed-by? - Arnaldo > - Arnaldo > > > Thanks, > > Ian > > > > > This patch is on top of: > > > https://lore.kernel.org/lkml/20211124001231.3277836-1-irogers@google.com/ > > > > > > Signed-off-by: Ian Rogers > > > --- > > > tools/perf/pmu-events/jevents.c | 2 -- > > > tools/perf/util/expr.c | 2 +- > > > 2 files changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c > > > index 2e7c4153875b..1a57c3f81dd4 100644 > > > --- a/tools/perf/pmu-events/jevents.c > > > +++ b/tools/perf/pmu-events/jevents.c > > > @@ -672,8 +672,6 @@ static int json_events(const char *fn, > > > addfield(map, &je.metric_constraint, "", "", val); > > > } else if (json_streq(map, field, "MetricExpr")) { > > > addfield(map, &je.metric_expr, "", "", val); > > > - for (s = je.metric_expr; *s; s++) > > > - *s = tolower(*s); > > > } else if (json_streq(map, field, "ArchStdEvent")) { > > > addfield(map, &arch_std, "", "", val); > > > for (s = arch_std; *s; s++) > > > diff --git a/tools/perf/util/expr.c b/tools/perf/util/expr.c > > > index cdbab4f959fe..5cd6b9ff2489 100644 > > > --- a/tools/perf/util/expr.c > > > +++ b/tools/perf/util/expr.c > > > @@ -397,7 +397,7 @@ double expr__get_literal(const char *literal) > > > static struct cpu_topology *topology; > > > double result = NAN; > > > > > > - if (!strcmp("#smt_on", literal)) { > > > + if (!strcasecmp("#smt_on", literal)) { > > > result = smt_on() > 0 ? 1.0 : 0.0; > > > goto out; > > > } > > > -- > > > 2.34.0.rc2.393.gf8c9666880-goog > > > > > -- > > - Arnaldo -- - Arnaldo