From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: John Garry <john.garry@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, irogers@google.com,
kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, zhengjun.xing@linux.intel.com
Subject: Re: [PATCH v2] perf pmu: Fix alias events list
Date: Sun, 2 Jan 2022 11:34:23 -0300 [thread overview]
Message-ID: <YdG378o4kx4zbRSo@kernel.org> (raw)
In-Reply-To: <05dcd009-084c-b8ee-c4a5-35c0862ee26d@huawei.com>
Em Tue, Dec 28, 2021 at 09:00:18PM +0000, John Garry escreveu:
> On 21/12/2021 16:11, John Garry wrote:
> > Commit 0e0ae8742207 ("perf list: Display hybrid PMU events with cpu type")
> > changes the event list for uncore PMUs or arm64 heterogeneous CPU systems,
> > such that duplicate aliases are incorrectly listed per PMU (which they
> > should not be), like:
> >
> > ./perf list
> > ...
> > unc_cbo_cache_lookup.any_es
> > [Unit: uncore_cbox L3 Lookup any request that access cache and found
> > line in E or S-state]
> > unc_cbo_cache_lookup.any_es
> > [Unit: uncore_cbox L3 Lookup any request that access cache and found
> > line in E or S-state]
> > unc_cbo_cache_lookup.any_i
> > [Unit: uncore_cbox L3 Lookup any request that access cache and found
> > line in I-state]
> > unc_cbo_cache_lookup.any_i
> > [Unit: uncore_cbox L3 Lookup any request that access cache and found
> > line in I-state]
> > ...
> >
> > Notice how the events are listed twice.
>
>
> Hi Arnaldo,
>
> Can you kindly consider picking up this change for v5.16?
Applied, will send a pull req to Linus soon.
- Arnaldo
prev parent reply other threads:[~2022-01-02 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 16:11 [PATCH v2] perf pmu: Fix alias events list John Garry
2021-12-22 6:56 ` Xing Zhengjun
2021-12-28 21:00 ` John Garry
2022-01-02 14:34 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdG378o4kx4zbRSo@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).