From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4765EC433F5 for ; Thu, 6 Jan 2022 20:22:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243663AbiAFUWY (ORCPT ); Thu, 6 Jan 2022 15:22:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235063AbiAFUWW (ORCPT ); Thu, 6 Jan 2022 15:22:22 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B44F8C061245 for ; Thu, 6 Jan 2022 12:22:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7B9DDB823A5 for ; Thu, 6 Jan 2022 20:22:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12AC0C36AE5; Thu, 6 Jan 2022 20:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641500540; bh=H4w3A6VByOUcCRld741J5OK7sU1s2CzEM5LVp56vXLM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ROFMzrv+6dCJkgakWy1x0tKtpQEZeLZwmb8vgdylsG5UuUrLyceZIhDX6Eo1jaqhs VeT1tBwftWQh9ITd1qroECXvXoLzo59+NMQ/1CaxrOGupUkNQubcNKGyJuUzfwDX14 iCfEH2d12MsiQlqgbe/gFa17sdnJqmKgt5qCLdZc4mCUmSuetDc7uQK0VPy3MFk1OM NMuIa+Qy3gmUhOIBr7HbPBTV75gkkYanLZxZn6iMgKbj7Ks4SrRNoWAQ26v/Cbk2bh BbtJoE4ZHcH8slqrirjXWPtG9Dhg5pXDPCLW6HnNT5PWMh1grHLjSyc2mBwdX6fpGP Xl1GF+V2A+UBg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 885DE40B92; Thu, 6 Jan 2022 17:22:17 -0300 (-03) Date: Thu, 6 Jan 2022 17:22:17 -0300 From: Arnaldo Carvalho de Melo To: Athira Rajeev Cc: Jiri Olsa , Michael Ellerman , linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, maddy@linux.vnet.ibm.com, kajoljain , Namhyung Kim , Nageswara Sastry Subject: Re: [PATCH V2 1/2] tools/perf: Include global and local variants for p_stage_cyc sort key Message-ID: References: <20211203022038.48240-1-atrajeev@linux.vnet.ibm.com> <9FCC0543-29A8-455D-B2BC-299B332F45D2@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9FCC0543-29A8-455D-B2BC-299B332F45D2@linux.vnet.ibm.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Thu, Jan 06, 2022 at 04:21:05PM +0530, Athira Rajeev escreveu: > > > > On 08-Dec-2021, at 9:21 AM, Nageswara Sastry wrote: > > > > > > > > On 07/12/21 8:22 pm, Arnaldo Carvalho de Melo wrote: > >> Em Fri, Dec 03, 2021 at 07:50:37AM +0530, Athira Rajeev escreveu: > >>> Sort key p_stage_cyc is used to present the latency > >>> cycles spend in pipeline stages. perf tool has local > >>> p_stage_cyc sort key to display this info. There is no > >>> global variant available for this sort key. local variant > >>> shows latency in a sinlge sample, whereas, global value > >>> will be useful to present the total latency (sum of > >>> latencies) in the hist entry. It represents latency > >>> number multiplied by the number of samples. > >>> > >>> Add global (p_stage_cyc) and local variant > >>> (local_p_stage_cyc) for this sort key. Use the > >>> local_p_stage_cyc as default option for "mem" sort mode. > >>> Also add this to list of dynamic sort keys and made the > >>> "dynamic_headers" and "arch_specific_sort_keys" as static. > >>> > >>> Signed-off-by: Athira Rajeev > >>> Reported-by: Namhyung Kim > >> I got this for v1, does it stand for v2? > >> Tested-by: Nageswara R Sastry > > > > > > Tested with v2 also. > > Hi Arnaldo, > > If this patchset looks fine to you, can you please consider pulling it. Thanks, applied to perf/core, for 5.17. - Arnaldo