From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Shunsuke Nakamura <nakamura.shun@fujitsu.com>,
Colin Ian King <colin.king@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libperf tests: Update a use of the new cpumap api.
Date: Fri, 14 Jan 2022 11:34:08 -0300 [thread overview]
Message-ID: <YeGJ4PJOQRwNVThV@kernel.org> (raw)
In-Reply-To: <20220114065105.1806542-1-irogers@google.com>
Em Thu, Jan 13, 2022 at 10:51:05PM -0800, Ian Rogers escreveu:
> Fixes a build breakage.
>
> Fixes: 6d18804b963b ("perf cpumap: Give CPUs their own type")
I wonder how I didn't catch this in my tests...
Thanks, applied.
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/lib/perf/tests/test-evlist.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/perf/tests/test-evlist.c b/tools/lib/perf/tests/test-evlist.c
> index e7afff12c35a..b3479dfa9a1c 100644
> --- a/tools/lib/perf/tests/test-evlist.c
> +++ b/tools/lib/perf/tests/test-evlist.c
> @@ -334,7 +334,8 @@ static int test_mmap_cpus(void)
> };
> cpu_set_t saved_mask;
> char path[PATH_MAX];
> - int id, err, cpu, tmp;
> + int id, err, tmp;
> + struct perf_cpu cpu;
> union perf_event *event;
> int count = 0;
>
> @@ -377,7 +378,7 @@ static int test_mmap_cpus(void)
> cpu_set_t mask;
>
> CPU_ZERO(&mask);
> - CPU_SET(cpu, &mask);
> + CPU_SET(cpu.cpu, &mask);
>
> err = sched_setaffinity(0, sizeof(mask), &mask);
> __T("sched_setaffinity failed", err == 0);
> --
> 2.34.1.703.g22d0c6ccf7-goog
--
- Arnaldo
prev parent reply other threads:[~2022-01-14 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 6:51 [PATCH] libperf tests: Update a use of the new cpumap api Ian Rogers
2022-01-14 14:34 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeGJ4PJOQRwNVThV@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=colin.king@intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=nakamura.shun@fujitsu.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).