From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75CE9C433F5 for ; Sat, 22 Jan 2022 20:11:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbiAVULJ (ORCPT ); Sat, 22 Jan 2022 15:11:09 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:39486 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiAVULJ (ORCPT ); Sat, 22 Jan 2022 15:11:09 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B36B060EC1; Sat, 22 Jan 2022 20:11:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1FA2C004E1; Sat, 22 Jan 2022 20:11:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642882268; bh=Gt3uHFlxZVnfwBNagtr2hrQwUhWaSxv7EdJXOwuAYh4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZnMGefAPY0jX7fMDHouwVxS2VNNXp2LVQg9DP4ut2jmJ9TRG8NoNK/Mt7RnC8z9we /ClVthxk4qadO/C8ZHuxZggdD6UF45ByoZSr2ib5eF5+kwwEY4XfYobYrqL3qrJQWZ GgGbqu1fJc47m+AUuOan8BBA22Ck5bCm4Bm1YY3n3N2Yb77Zb4M+vkBfRL58xu59+Q /Ldi9MnjVcE4JXaHtCv6eAk5com2Ggl/Gg35jvJ++rfN7pbfm+mmZXO0luWalUvws9 gibbhjqeH5NuiODjwKAp5lm75kUp95nQiUFivsqPVLwaboSABMmYpO4nyf3UU6K7wt GMxSlmgqax7ng== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 90F3A40C99; Sat, 22 Jan 2022 17:09:05 -0300 (-03) Date: Sat, 22 Jan 2022 17:09:05 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Darren Hart , Davidlohr Bueso , =?iso-8859-1?Q?Andr=E9?= Almeida , James Clark , John Garry , Riccardo Mancini , Yury Norov , Andy Shevchenko , Andrew Morton , Jin Yao , Adrian Hunter , Leo Yan , Andi Kleen , Thomas Richter , Kan Liang , Madhavan Srinivasan , Shunsuke Nakamura , Song Liu , Masami Hiramatsu , Steven Rostedt , Miaoqian Lin , Stephen Brennan , Kajol Jain , Alexey Bayduraev , German Gomez , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Dmitry Vyukov , eranian@google.com Subject: Re: [PATCH 1/3] perf python: Fix cpu_map__item building Message-ID: References: <20220122045811.3402706-1-irogers@google.com> <20220122045811.3402706-2-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220122045811.3402706-2-irogers@google.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, Jan 21, 2022 at 08:58:09PM -0800, Ian Rogers escreveu: > Value should be built as an integer. > Switch some uses of perf_cpu_map to use the library API. > > Fixes: 6d18804b963b ("perf cpumap: Give CPUs their own type") > Signed-off-by: Ian Rogers Thanks, applied. - Arnaldo > --- > tools/perf/util/python.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c > index f3e5131f183c..52d8995cfd73 100644 > --- a/tools/perf/util/python.c > +++ b/tools/perf/util/python.c > @@ -638,17 +638,17 @@ static Py_ssize_t pyrf_cpu_map__length(PyObject *obj) > { > struct pyrf_cpu_map *pcpus = (void *)obj; > > - return pcpus->cpus->nr; > + return perf_cpu_map__nr(pcpus->cpus); > } > > static PyObject *pyrf_cpu_map__item(PyObject *obj, Py_ssize_t i) > { > struct pyrf_cpu_map *pcpus = (void *)obj; > > - if (i >= pcpus->cpus->nr) > + if (i >= perf_cpu_map__nr(pcpus->cpus)) > return NULL; > > - return Py_BuildValue("i", pcpus->cpus->map[i]); > + return Py_BuildValue("i", perf_cpu_map__cpu(pcpus->cpus, i).cpu); > } > > static PySequenceMethods pyrf_cpu_map__sequence_methods = { > -- > 2.35.0.rc0.227.g00780c9af4-goog -- - Arnaldo