* [PATCH] perf: tools: Add missing branch_sample_type
@ 2022-02-02 10:57 Anshuman Khandual
2022-02-02 16:55 ` Jiri Olsa
0 siblings, 1 reply; 3+ messages in thread
From: Anshuman Khandual @ 2022-02-02 10:57 UTC (permalink / raw)
To: linux-arm-kernel
Cc: james.clark, Anshuman Khandual, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, linux-perf-users,
linux-kernel
This updates branch sample type with missing PERF_SAMPLE_BRANCH_TYPE_SAVE.
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Suggested-by: James Clark <james.clark@arm.com>
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
tools/perf/util/perf_event_attr_fprintf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c
index 47b7531f51da..98af3fa4ea35 100644
--- a/tools/perf/util/perf_event_attr_fprintf.c
+++ b/tools/perf/util/perf_event_attr_fprintf.c
@@ -52,7 +52,7 @@ static void __p_branch_sample_type(char *buf, size_t size, u64 value)
bit_name(ABORT_TX), bit_name(IN_TX), bit_name(NO_TX),
bit_name(COND), bit_name(CALL_STACK), bit_name(IND_JUMP),
bit_name(CALL), bit_name(NO_FLAGS), bit_name(NO_CYCLES),
- bit_name(HW_INDEX),
+ bit_name(TYPE_SAVE), bit_name(HW_INDEX),
{ .name = NULL, }
};
#undef bit_name
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf: tools: Add missing branch_sample_type
2022-02-02 10:57 [PATCH] perf: tools: Add missing branch_sample_type Anshuman Khandual
@ 2022-02-02 16:55 ` Jiri Olsa
2022-02-06 11:36 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Olsa @ 2022-02-02 16:55 UTC (permalink / raw)
To: Anshuman Khandual
Cc: linux-arm-kernel, james.clark, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, linux-perf-users,
linux-kernel
On Wed, Feb 02, 2022 at 04:27:23PM +0530, Anshuman Khandual wrote:
> This updates branch sample type with missing PERF_SAMPLE_BRANCH_TYPE_SAVE.
>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-perf-users@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Suggested-by: James Clark <james.clark@arm.com>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
> ---
> tools/perf/util/perf_event_attr_fprintf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c
> index 47b7531f51da..98af3fa4ea35 100644
> --- a/tools/perf/util/perf_event_attr_fprintf.c
> +++ b/tools/perf/util/perf_event_attr_fprintf.c
> @@ -52,7 +52,7 @@ static void __p_branch_sample_type(char *buf, size_t size, u64 value)
> bit_name(ABORT_TX), bit_name(IN_TX), bit_name(NO_TX),
> bit_name(COND), bit_name(CALL_STACK), bit_name(IND_JUMP),
> bit_name(CALL), bit_name(NO_FLAGS), bit_name(NO_CYCLES),
> - bit_name(HW_INDEX),
> + bit_name(TYPE_SAVE), bit_name(HW_INDEX),
> { .name = NULL, }
> };
> #undef bit_name
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf: tools: Add missing branch_sample_type
2022-02-02 16:55 ` Jiri Olsa
@ 2022-02-06 11:36 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-02-06 11:36 UTC (permalink / raw)
To: Jiri Olsa
Cc: Anshuman Khandual, linux-arm-kernel, james.clark, Peter Zijlstra,
Ingo Molnar, Mark Rutland, linux-perf-users, linux-kernel
Em Wed, Feb 02, 2022 at 05:55:45PM +0100, Jiri Olsa escreveu:
> On Wed, Feb 02, 2022 at 04:27:23PM +0530, Anshuman Khandual wrote:
> > This updates branch sample type with missing PERF_SAMPLE_BRANCH_TYPE_SAVE.
> >
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: linux-perf-users@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Suggested-by: James Clark <james.clark@arm.com>
> > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
Thanks, applied.
- Arnaldo
> thanks,
> jirka
>
> > ---
> > tools/perf/util/perf_event_attr_fprintf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c
> > index 47b7531f51da..98af3fa4ea35 100644
> > --- a/tools/perf/util/perf_event_attr_fprintf.c
> > +++ b/tools/perf/util/perf_event_attr_fprintf.c
> > @@ -52,7 +52,7 @@ static void __p_branch_sample_type(char *buf, size_t size, u64 value)
> > bit_name(ABORT_TX), bit_name(IN_TX), bit_name(NO_TX),
> > bit_name(COND), bit_name(CALL_STACK), bit_name(IND_JUMP),
> > bit_name(CALL), bit_name(NO_FLAGS), bit_name(NO_CYCLES),
> > - bit_name(HW_INDEX),
> > + bit_name(TYPE_SAVE), bit_name(HW_INDEX),
> > { .name = NULL, }
> > };
> > #undef bit_name
> > --
> > 2.20.1
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-06 11:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-02 10:57 [PATCH] perf: tools: Add missing branch_sample_type Anshuman Khandual
2022-02-02 16:55 ` Jiri Olsa
2022-02-06 11:36 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).