From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8488C433EF for ; Wed, 2 Feb 2022 10:08:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234704AbiBBKIs (ORCPT ); Wed, 2 Feb 2022 05:08:48 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:37764 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbiBBKIs (ORCPT ); Wed, 2 Feb 2022 05:08:48 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 32A21B8306A; Wed, 2 Feb 2022 10:08:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA298C004E1; Wed, 2 Feb 2022 10:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643796526; bh=IIDVZd6xhg6IbKtZ7hn0mo9CpKwGO0GZzXu6zIWWUuc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gXyTvIbeQus088m8DJUWfdrOTMtXiau/N40xSfaraPhhbzauYgkC30Ne383DsiAaI Zt7WEywKQrPxDAY3C2U9miaKco+9rQ3ANN6gsUkxJWCNlP6PWwlo0BdtLfSLGNvwjY ud0Y5njlfGiOYk8HnNN4cwOu5EVf1KHAmM3XkYCvSVzkHXacSsWYVQJfJcGlA4YUUm vysLI7zvZn2d2kAGY6BUFJJoKLeymJcMF27n3UIsBymrRu8hWTw9wV1aABQ/eDUqwc RkG59IPjpWmDj2U7qUA4yGptkANS5z++URAqdc5IFpavY+X226xnSiq8IAOUSdJSwC u5Md2OlKe69mg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id ECA8A40466; Wed, 2 Feb 2022 07:08:42 -0300 (-03) Date: Wed, 2 Feb 2022 07:08:42 -0300 From: Arnaldo Carvalho de Melo To: Andrii Nakryiko Cc: Jiri Olsa , Peter Zijlstra , Ingo Molnar , Mark Rutland , Namhyung Kim , Alexander Shishkin , Michael Petlan , Ian Rogers , "linux-perf-use." , Christy Lee , Andrii Nakryiko , bpf Subject: Re: [PATCH 1/3] perf/bpf: Remove prologue generation Message-ID: References: <20220123221932.537060-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Tue, Feb 01, 2022 at 05:01:38PM -0800, Andrii Nakryiko escreveu: > On Mon, Jan 24, 2022 at 12:24 PM Andrii Nakryiko > wrote: > > > > On Sun, Jan 23, 2022 at 2:19 PM Jiri Olsa wrote: > > > > > > Removing code for ebpf program prologue generation. > > > > > > The prologue code was used to get data for extra arguments specified > > > in program section name, like: > > > > > > SEC("lock_page=__lock_page page->flags") > > > int lock_page(struct pt_regs *ctx, int err, unsigned long flags) > > > { > > > return 1; > > > } > > > > > > This code is using deprecated libbpf API and blocks its removal. > > > > > > This feature was not documented and broken for some time without > > > anyone complaining, also original authors are not responding, > > > so I'm removing it. > > > > > > Signed-off-by: Jiri Olsa > > > --- > > > tools/perf/Makefile.config | 11 - > > > tools/perf/builtin-record.c | 14 - > > > tools/perf/util/bpf-loader.c | 242 +--------------- > > > tools/perf/util/bpf-prologue.c | 508 --------------------------------- > > > tools/perf/util/bpf-prologue.h | 37 --- > > > 5 files changed, 1 insertion(+), 811 deletions(-) > > > > Love the stats! Thanks for taking this on! > > > > Hi, > > Was this ever applied? If not, are there any blockers? I assume this > will go through the perf tree, right? I'll go thru it today. > > > delete mode 100644 tools/perf/util/bpf-prologue.c > > > delete mode 100644 tools/perf/util/bpf-prologue.h > > > > > > > [...] -- - Arnaldo