From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4CD5C433F5 for ; Sat, 5 Mar 2022 19:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232221AbiCETOG (ORCPT ); Sat, 5 Mar 2022 14:14:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230022AbiCETOF (ORCPT ); Sat, 5 Mar 2022 14:14:05 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EED51DF3; Sat, 5 Mar 2022 11:13:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7AFD960B58; Sat, 5 Mar 2022 19:13:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96A5FC004E1; Sat, 5 Mar 2022 19:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646507593; bh=ismCCXTQN4wRCQCh0iN8ukxF4lK+mQ4/GREdYf3TjbA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AaAVBuzRjfjoeHXPcCDbsYEY6FYB+MB7x0U30ugLRbtGOf6xm0Xdn9VxkPcC2wWKV Rf98iyA7igwEvWFKG696RBSIO3ke+tw2ZzC4LhCsg7inaLR9sChckCJUhBT5Q4xlyf hGexSd5xg0qFXZVjg1Wv2MpkF+8EtVokfFXVtQ+JNIweif5g87a9fCWrgCryrBpfUf vHJPCUj++EU8McL1o7lGAT8k35o7FqbGEGFbti2SYPi/e/XsohASkaDl4Vjxzi3tyu 0vfUPXL5fb3ulsGAHjIQre7VID89ckDEb3sXmTy6EU1Vcskuwhe49F9UfYcBmNEg7Y yL3xAPvlIhs4g== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 78027403C8; Sat, 5 Mar 2022 16:13:09 -0300 (-03) Date: Sat, 5 Mar 2022 16:13:09 -0300 From: Arnaldo Carvalho de Melo To: Andrii Nakryiko Cc: Jiri Olsa , lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Namhyung Kim , Alexander Shishkin , Ian Rogers , "linux-perf-use." , bpf , Andrii Nakryiko Subject: Re: [PATCHv3 0/2] perf/bpf: Replace deprecated code Message-ID: References: <20220224155238.714682-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Feb 28, 2022 at 05:49:55PM -0800, Andrii Nakryiko escreveu: > On Thu, Feb 24, 2022 at 7:52 AM Jiri Olsa wrote: > > > > hi, > > the original patchset [1] removed the whole perf functionality > > with the hope nobody's using that. But it turned out there's > > actually bpf script using prologue functionality, so there > > might be users of this. > > > > v3 changes: > > - sending priv related changes, because they can be already > > merged, the rest will need more discussion and work > > > > - this version gets rid of and adds workaround (and keeps the > > current functionality) for following deprecated libbpf functions: > > > > bpf_program__set_priv > > bpf_program__priv > > bpf_map__set_priv > > bpf_map__priv > > > > Basically it implements workarounds suggested by Andrii in [2]. > > > > LGTM, for the series: > > Acked-by: Andrii Nakryiko Thanks, applied. - Arnaldo > > Also available in here: > > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > > bpf/depre > > > > thanks, > > jirka > > > > > > [1] https://lore.kernel.org/linux-perf-users/YgoPxhE3OEEmZqla@krava/T/#t > > [2] https://lore.kernel.org/linux-perf-users/YgoPxhE3OEEmZqla@krava/T/#md3ccab9fe70a4583e94603b1a562e369bd67b17d > > --- > > Jiri Olsa (2): > > perf tools: Remove bpf_program__set_priv/bpf_program__priv usage > > perf tools: Remove bpf_map__set_priv/bpf_map__priv usage > > > > tools/perf/util/bpf-loader.c | 164 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------- > > 1 file changed, 141 insertions(+), 23 deletions(-) -- - Arnaldo