From: "Steinar H. Gunderson" <sesse@google.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf intel-pt: Synthesize cycle events
Date: Wed, 16 Mar 2022 09:19:44 +0100 [thread overview]
Message-ID: <YjGdoGy4Z2UUG9S9@google.com> (raw)
In-Reply-To: <52903e58-e74c-5ea0-36b4-277ea3610af4@intel.com>
On Tue, Mar 15, 2022 at 10:11:54PM +0200, Adrian Hunter wrote:
> Sorry, my first suggestion has issues, but the second is better.
I tried your second one, but can't see much difference. The original and
your patched version still differ by a lot, and I still see various
non-branch instructions getting very tiny fractions. (PSB packets
_might_ be it, as there are ~1000 of them in the 165M-cycle trace.)
I guess the good news is that the perf report coming out of your version
looks more likely to me; I have some functions that are around 1% that
shouldn't intuitively be that much (and, if I write some Perl to sum up
the cycles from the IPC lines in perf script, are more around 0.1%).
So perhaps we should stop chasing the difference? I don't know.
/* Steinar */
next prev parent reply other threads:[~2022-03-16 8:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 9:38 [PATCH] perf intel-pt: Synthesize cycle events Steinar H. Gunderson
2022-03-11 9:10 ` Adrian Hunter
2022-03-11 17:42 ` Steinar H. Gunderson
2022-03-14 16:24 ` Adrian Hunter
2022-03-15 10:16 ` Steinar H. Gunderson
2022-03-15 11:32 ` Adrian Hunter
2022-03-15 18:00 ` Steinar H. Gunderson
2022-03-15 20:11 ` Adrian Hunter
2022-03-16 8:19 ` Steinar H. Gunderson [this message]
2022-03-16 11:19 ` Adrian Hunter
2022-03-16 12:59 ` Steinar H. Gunderson
2022-03-21 9:16 ` Adrian Hunter
2022-03-21 10:33 ` Steinar H. Gunderson
2022-03-21 13:09 ` Adrian Hunter
2022-03-21 16:58 ` Steinar H. Gunderson
2022-03-21 17:40 ` Adrian Hunter
2022-03-22 11:57 ` Steinar H. Gunderson
2022-03-29 12:31 ` Steinar H. Gunderson
2022-03-29 14:16 ` Steinar H. Gunderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjGdoGy4Z2UUG9S9@google.com \
--to=sesse@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).