* [PATCH] perf parse-events: Ignore case in topdown.slots check
@ 2022-03-17 22:43 Ian Rogers
2022-03-18 14:28 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2022-03-17 22:43 UTC (permalink / raw)
To: Kan Liang, Zhengjun Xing, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, Maxime Coquelin, Alexandre Torgue,
Andi Kleen, James Clark, John Garry, linux-kernel,
linux-perf-users
Cc: Stephane Eranian, Ian Rogers, Caleb Biggers
An issue with icelakex metrics:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json?h=perf/core&id=65eab2bc7dab326ee892ec5a4c749470b368b51a#n48
That causes the slots not to be first.
Fixes: 94dbfd6781a0 ("perf parse-events: Architecture specific leader override")
Reported-by: Caleb Biggers <caleb.biggers@intel.com>
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/arch/x86/util/evlist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/arch/x86/util/evlist.c b/tools/perf/arch/x86/util/evlist.c
index f924246eff78..8d9b55959256 100644
--- a/tools/perf/arch/x86/util/evlist.c
+++ b/tools/perf/arch/x86/util/evlist.c
@@ -29,7 +29,7 @@ struct evsel *arch_evlist__leader(struct list_head *list)
__evlist__for_each_entry(list, evsel) {
if (evsel->pmu_name && !strcmp(evsel->pmu_name, "cpu") &&
- evsel->name && strstr(evsel->name, "slots"))
+ evsel->name && strcasestr(evsel->name, "slots"))
return evsel;
}
return first;
--
2.35.1.894.gb6a874cedc-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf parse-events: Ignore case in topdown.slots check
2022-03-17 22:43 [PATCH] perf parse-events: Ignore case in topdown.slots check Ian Rogers
@ 2022-03-18 14:28 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-03-18 14:28 UTC (permalink / raw)
To: Ian Rogers
Cc: Kan Liang, Zhengjun Xing, Peter Zijlstra, Ingo Molnar,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Maxime Coquelin, Alexandre Torgue, Andi Kleen, James Clark,
John Garry, linux-kernel, linux-perf-users, Stephane Eranian,
Caleb Biggers
Em Thu, Mar 17, 2022 at 03:43:09PM -0700, Ian Rogers escreveu:
> An issue with icelakex metrics:
> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json?h=perf/core&id=65eab2bc7dab326ee892ec5a4c749470b368b51a#n48
> That causes the slots not to be first.
Thanks, applied.
- Arnaldo
> Fixes: 94dbfd6781a0 ("perf parse-events: Architecture specific leader override")
> Reported-by: Caleb Biggers <caleb.biggers@intel.com>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/arch/x86/util/evlist.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/x86/util/evlist.c b/tools/perf/arch/x86/util/evlist.c
> index f924246eff78..8d9b55959256 100644
> --- a/tools/perf/arch/x86/util/evlist.c
> +++ b/tools/perf/arch/x86/util/evlist.c
> @@ -29,7 +29,7 @@ struct evsel *arch_evlist__leader(struct list_head *list)
>
> __evlist__for_each_entry(list, evsel) {
> if (evsel->pmu_name && !strcmp(evsel->pmu_name, "cpu") &&
> - evsel->name && strstr(evsel->name, "slots"))
> + evsel->name && strcasestr(evsel->name, "slots"))
> return evsel;
> }
> return first;
> --
> 2.35.1.894.gb6a874cedc-goog
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-18 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-17 22:43 [PATCH] perf parse-events: Ignore case in topdown.slots check Ian Rogers
2022-03-18 14:28 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).