linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Tanu M <tanu235m@gmail.com>
Cc: linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org
Subject: Re: [PATCH] perf tools/perf/python/tracepoint.py: Converted to Python3
Date: Wed, 30 Mar 2022 17:39:07 -0300	[thread overview]
Message-ID: <YkS/6xjPDa/JevcQ@kernel.org> (raw)
In-Reply-To: <CAPS78prawYzRZnyhWjgOnGw4EwoswNwztvfZFdCOPOydFzVwzQ@mail.gmail.com>

Em Sun, Mar 27, 2022 at 11:08:46PM -0700, Tanu M escreveu:
> Hi,
> I have converted the tracepoint.py file to python3 as many of the
> files in tools/perf are already written in python3.
> 
> Signed-off-by: Tanusree Debnath <tanu235m@gmail.com>

Got this:

⬢[acme@toolbox perf]$ patch -p1 < ~/wb/1.patch
patching file tools/perf/python/tracepoint.py
patch: **** malformed patch at line 119: prev_state=0x%x ==> next_comm=%s next_pid=%d next_prio=%d" % (

⬢[acme@toolbox perf]$

I'll apply it by hand, please check your e-mail client.

- Arnaldo
 
> ---
>  tools/perf/python/tracepoint.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/python/tracepoint.py b/tools/perf/python/tracepoint.py
> index 461848c7f..6a63e6c41 100755
> --- a/tools/perf/python/tracepoint.py
> +++ b/tools/perf/python/tracepoint.py
> @@ -34,7 +34,7 @@ def main():
>              if not isinstance(event, perf.sample_event):
>                  continue
> 
> -            print "time %u prev_comm=%s prev_pid=%d prev_prio=%d
> prev_state=0x%x ==> next_comm=%s next_pid=%d next_prio=%d" % (
> +            print ("time %u prev_comm=%s prev_pid=%d prev_prio=%d
> prev_state=0x%x ==> next_comm=%s next_pid=%d next_prio=%d" % (
>                     event.sample_time,
>                     event.prev_comm,
>                     event.prev_pid,
> @@ -42,7 +42,7 @@ def main():
>                     event.prev_state,
>                     event.next_comm,
>                     event.next_pid,
> -                   event.next_prio)
> +                   event.next_prio))
> 
>  if __name__ == '__main__':
>      main()
> -- 
> 2.25.1

-- 

- Arnaldo

  reply	other threads:[~2022-03-30 20:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28  6:08 [PATCH] perf tools/perf/python/tracepoint.py: Converted to Python3 Tanu M
2022-03-30 20:39 ` Arnaldo Carvalho de Melo [this message]
2022-03-30 20:47   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkS/6xjPDa/JevcQ@kernel.org \
    --to=acme@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tanu235m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).