From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: "John Garry" <john.garry@huawei.com>,
"Will Deacon" <will@kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Leo Yan" <leo.yan@linaro.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"James Clark" <james.clark@arm.com>,
"Alexandre Truong" <alexandre.truong@arm.com>,
"German Gomez" <german.gomez@arm.com>,
"Dave Marchevsky" <davemarchevsky@fb.com>,
"Song Liu" <songliubraving@fb.com>,
"Ravi Bangoria" <ravi.bangoria@amd.com>,
"Li Huafei" <lihuafei1@huawei.com>,
"Martin Liška" <mliska@suse.cz>,
"William Cohen" <wcohen@redhat.com>,
"Riccardo Mancini" <rickyman7@gmail.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Thomas Richter" <tmricht@linux.ibm.com>,
"Lexi Shao" <shaolexi@huawei.com>,
"Remi Bernon" <rbernon@codeweavers.com>,
"Michael Petlan" <mpetlan@redhat.com>,
"Denis Nikitin" <denik@chromium.org>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
"Stephane Eranian" <eranian@google.com>
Subject: Re: [PATCH 1/5] perf annotate: Drop objdump stderr
Date: Sat, 9 Apr 2022 12:44:56 -0300 [thread overview]
Message-ID: <YlGp+EVwne5QbjtY@kernel.org> (raw)
In-Reply-To: <20220407230503.1265036-2-irogers@google.com>
Em Thu, Apr 07, 2022 at 04:04:59PM -0700, Ian Rogers escreveu:
> If objdump writes to stderr it can block waiting for it to be read. As
> perf doesn't read stderr then progress stops with perf waiting for
> stdout output.
Thanks, applied.
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/annotate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index e4c641b240df..82cc396ef516 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -2047,6 +2047,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args)
> objdump_process.argv = objdump_argv;
> objdump_process.out = -1;
> objdump_process.err = -1;
> + objdump_process.no_stderr = 1;
> if (start_command(&objdump_process)) {
> pr_err("Failure starting to run %s\n", command);
> err = -1;
> --
> 2.35.1.1178.g4f1659d476-goog
--
- Arnaldo
next prev parent reply other threads:[~2022-04-09 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 23:04 [PATCH 0/5] Tidy up symbol end fixup Ian Rogers
2022-04-07 23:04 ` [PATCH 1/5] perf annotate: Drop objdump stderr Ian Rogers
2022-04-09 15:44 ` Arnaldo Carvalho de Melo [this message]
2022-04-07 23:05 ` [PATCH 2/5] perf symbols: Always do architecture specific fixups Ian Rogers
2022-04-07 23:05 ` [PATCH 3/5] perf symbols: Add is_kernel argument to fixup end Ian Rogers
2022-04-07 23:05 ` [PATCH 4/5] perf symbol: By default only fix zero length symbols Ian Rogers
2022-04-07 23:05 ` [PATCH 5/5] perf symbols: More specific architecture end fixing Ian Rogers
2022-04-08 17:15 ` [PATCH 0/5] Tidy up symbol end fixup Namhyung Kim
2022-04-08 23:52 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlGp+EVwne5QbjtY@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.truong@arm.com \
--cc=davemarchevsky@fb.com \
--cc=denik@chromium.org \
--cc=eranian@google.com \
--cc=german.gomez@arm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=lihuafei1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=rbernon@codeweavers.com \
--cc=rickyman7@gmail.com \
--cc=shaolexi@huawei.com \
--cc=songliubraving@fb.com \
--cc=tmricht@linux.ibm.com \
--cc=wcohen@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).