From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E85EC433FE for ; Thu, 28 Apr 2022 13:52:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235827AbiD1Nzt (ORCPT ); Thu, 28 Apr 2022 09:55:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235821AbiD1Nzs (ORCPT ); Thu, 28 Apr 2022 09:55:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BE03694A2; Thu, 28 Apr 2022 06:52:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C17B0B82D0B; Thu, 28 Apr 2022 13:52:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5544CC385A9; Thu, 28 Apr 2022 13:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651153951; bh=ODsMq+Ft6dlX/IlXg4fQJ5/+B9MFbJhJJW4Q4ktgLxw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eAQ2tkW+noTloQZoa3bawPAwbQnElGK0hQb/COxBVytIy6TX2Ejj95XwXO+nGKI4V a35LPeQNI3AIi+uz4Y2X02zHmwACwr/q+20eHNrLBfNE34fNxJ2KeHgsln3ygah9pt vhlJAX11NIXY1yVt0UyfYUE9G4vJ9G1RSxC1sCkzDZuGtWCJji9+r52pOdC0Mijy9S dzOH2OrF9bf3tm5tZARzRxaFs1rhiUgKa5f2T/po64gaLVpRdYVu+nYCGECuapIQbR M8KBuFnmaSCBXBMpURObGEofM5FOAzBsH3evsgzBAR7rnlFndWKvQOtFKy9+0mykuQ Lq6lRBWsKXJFA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D0F09400B1; Thu, 28 Apr 2022 10:52:28 -0300 (-03) Date: Thu, 28 Apr 2022 10:52:28 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Namhyung Kim , Jiri Olsa , Michael Petlan , Peter Zijlstra , Ingo Molnar , Masami Hiramatsu , Song Liu , Will Deacon , Mark Rutland , John Garry , Mathieu Poirier , Leo Yan , Michael Ellerman , Heiko Carstens , LKML , linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 0/3] perf tools: Tidy up symbol end fixup (v3) Message-ID: References: <20220416004048.1514900-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Apr 25, 2022 at 01:59:03PM -0700, Ian Rogers escreveu: > On Fri, Apr 15, 2022 at 5:40 PM Namhyung Kim wrote: > > > > Hello, > > > > This work is a follow-up of Ian's previous one at > > https://lore.kernel.org/all/20220412154817.2728324-1-irogers@google.com/ > > > > Fixing up more symbol ends as introduced in: > > https://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@redhat.com/ > > > > it caused perf annotate to run into memory limits - every symbol holds > > all the disassembled code in the annotation, and so making symbols > > ends further away dramatically increased memory usage (40MB to >1GB). > > > > Modify the symbol end fixup logic so that special kernel cases aren't > > applied in the common case. > > > > v3 changes) > > * rename is_kernel to is_kallsyms > > * move the logic to generic function > > * remove arch-specific functions > > > > Thanks, > > Namhyung > > Thanks Namhyung! The series: > > Acked-by: Ian Rogers Thanks, applied to perf/urgent. - Arnaldo > > Namhyung Kim (3): > > perf symbol: Pass is_kallsyms to symbols__fixup_end() > > perf symbol: Update symbols__fixup_end() > > perf symbol: Remove arch__symbols__fixup_end() > > > > tools/perf/arch/arm64/util/machine.c | 21 --------------- > > tools/perf/arch/powerpc/util/Build | 1 - > > tools/perf/arch/powerpc/util/machine.c | 25 ----------------- > > tools/perf/arch/s390/util/machine.c | 16 ----------- > > tools/perf/util/symbol-elf.c | 2 +- > > tools/perf/util/symbol.c | 37 +++++++++++++++++++------- > > tools/perf/util/symbol.h | 3 +-- > > 7 files changed, 29 insertions(+), 76 deletions(-) > > delete mode 100644 tools/perf/arch/powerpc/util/machine.c > > > > > > base-commit: 41204da4c16071be9090940b18f566832d46becc > > -- > > 2.36.0.rc0.470.gd361397f0d-goog > > -- - Arnaldo