From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25E6C433EF for ; Wed, 11 May 2022 18:29:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346243AbiEKS3s (ORCPT ); Wed, 11 May 2022 14:29:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345408AbiEKS3s (ORCPT ); Wed, 11 May 2022 14:29:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71F35197F67; Wed, 11 May 2022 11:29:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E8B761E1A; Wed, 11 May 2022 18:29:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45FF0C340EE; Wed, 11 May 2022 18:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652293786; bh=HBOd0ZkMSEn+UOVug8AD28JH1CWrZPyRrZIw2S8yaqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e1rE47TZWdU10CTV8JdlpQPDrq0zqBnMut8MBRlunF2eoj12wiyNOBPWwcQcrg2Z9 qZsKJDwxKdJUn8GaRwj9VTqFp0lvcXkcrER7KO+9NbMHcQgrdzOgYhtWJhuo6oMW7r S1CWo+W6GN2gjlL/ei/BVXKs9Uvqj+rVKzf9mj+UD2RA+QAGIRokZmXayj3AFO8fXN R2YhRsIx1Lr9eVBbLwLmfoxll+zKCLDJi/tKJLtpLtswPYsOKOf4YMAhAUX2hEnsro FStY3fQHuRS0t0cyL+MBMHVB2oJh+64YkImNUU6uNjDJxM7WK/Wx83ne5jTaazRPFg 8TaV+qUdc8LkQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 23FF6400B1; Wed, 11 May 2022 15:29:44 -0300 (-03) Date: Wed, 11 May 2022 15:29:44 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ali Saidi , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, german.gomez@arm.com, benh@kernel.crashing.org, Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH v8 2/5] perf tools: sync addition of PERF_MEM_SNOOPX_PEER Message-ID: References: <20220504184850.24986-1-alisaidi@amazon.com> <20220504184850.24986-3-alisaidi@amazon.com> <20220511022004.GA956170@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Wed, May 11, 2022 at 03:28:00PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, May 11, 2022 at 10:20:04AM +0800, Leo Yan escreveu: > > On Tue, May 10, 2022 at 01:28:38PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Wed, May 04, 2022 at 06:48:47PM +0000, Ali Saidi escreveu: > > > > Add a flag to the perf mem data struct to signal that a request caused a > > > > cache-to-cache transfer of a line from a peer of the requestor and > > > > wasn't sourced from a lower cache level. The line being moved from one > > > > peer cache to another has latency and performance implications. On Arm64 > > > > Neoverse systems the data source can indicate a cache-to-cache transfer > > > > but not if the line is dirty or clean, so instead of overloading HITM > > > > define a new flag that indicates this type of transfer. > > > > > > > > Signed-off-by: Ali Saidi > > > > Reviewed-by: Leo Yan > > > > > > Was this already merged on the ARM kernel tree? > > > > No, I don't think this patch has been merged on Arm kernel tree. I searched > > Arm and Arm64 git repos, none of them has merged this patch. > > > > https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?qt=author&q=Ali+Saidi > > http://git.armlinux.org.uk/cgit/linux-arm.git/log/?qt=author&q=Ali+Saidi > > > > P.s. Ali missed to include German's review tag, see: > > https://lore.kernel.org/lkml/458a2de1-dc93-7e2d-5dc5-fbcd670572b6@arm.com/ > > > > Do you want us to resend the patch set for adding tags? > > I use b4 and it should collect Reviewed-by, Acked-by, etc tags, for > instance, if I use the message-id in your message: > > ⬢[acme@toolbox perf]$ b4 am -ctsl --cc-trailers 20220511022004.GA956170@leoy-ThinkPad-X240s > Looking up https://lore.kernel.org/r/20220511022004.GA956170%40leoy-ThinkPad-X240s > Grabbing thread from lore.kernel.org/all/20220511022004.GA956170%40leoy-ThinkPad-X240s/t.mbox.gz > Checking for newer revisions on https://lore.kernel.org/all/ > Analyzing 12 messages in the thread > ✓ [PATCH v8 5/5] perf arm-spe: Use SPE data source for neoverse cores > + Signed-off-by: Arnaldo Carvalho de Melo > + Link: https://lore.kernel.org/r/20220504184850.24986-6-alisaidi@amazon.com > + Cc: Nick.Forrington@arm.com > + Cc: andrew.kilroy@arm.com > + Cc: james.clark@arm.com > + Cc: mark.rutland@arm.com > + Cc: john.garry@huawei.com > + Cc: lihuafei1@huawei.com > + Cc: peterz@infradead.org > + Cc: benh@kernel.crashing.org > + Cc: acme@kernel.org > + Cc: jolsa@kernel.org > + Cc: namhyung@kernel.org > + Cc: will@kernel.org > + Cc: mathieu.poirier@linaro.org > + Cc: kjain@linux.ibm.com > + Cc: alexander.shishkin@linux.intel.com > + Cc: linux-arm-kernel@lists.infradead.org > + Cc: mingo@redhat.com > + Cc: linux-kernel@vger.kernel.org > + Cc: linux-perf-users@vger.kernel.org > --- > ✓ Signed: DKIM/amazon.com > --- > Total patches: 5 > --- > Cover: ./v8_20220504_alisaidi_perf_arm_spe_decode_spe_source_and_use_for_perf_c2c.cover > Link: https://lore.kernel.org/r/20220504184850.24986-1-alisaidi@amazon.com > Base: not specified > git am ./v8_20220504_alisaidi_perf_arm_spe_decode_spe_source_and_use_for_perf_c2c.mbx > ⬢[acme@toolbox perf]$ > > Somehow it is not being collected... :-\ > > Not even when I use: > > > P.s. Ali missed to include German's review tag, see: > > https://lore.kernel.org/lkml/458a2de1-dc93-7e2d-5dc5-fbcd670572b6@arm.com/ > > > 458a2de1-dc93-7e2d-5dc5-fbcd670572b6@arm.com > > Will try updating b4... Didn't help, so please collect the new tags and resubmit. - Arnaldo