linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	broonie@kernel.org, german.gomez@arm.com, leo.yan@linaro.org,
	mathieu.poirier@linaro.org, john.garry@huawei.com,
	Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/5] perf: arm64: Tools support for Dwarf unwinding through SVE functions
Date: Thu, 26 May 2022 12:23:33 -0300	[thread overview]
Message-ID: <Yo+bdSMUOkd1N4HE@kernel.org> (raw)
In-Reply-To: <20220525154114.718321-1-james.clark@arm.com>

Em Wed, May 25, 2022 at 04:41:09PM +0100, James Clark escreveu:
> Changes since v2:
>   * Add commit to fix header include path to use Perf's copy
>   * Apply Leo's review tags
> 
> When SVE registers are pushed onto the stack the VG register is required to
> unwind because the stack offsets would vary by the SVE register width at the
> time when the sample was taken.
> 
> The patches ("[PATCH v2 0/2] perf: arm64: Kernel support for Dwarf unwinding
> through SVE functions") add support for sampling the VG register to the kernel
> and the docs. This is the patchset to add support to userspace perf.
> 
> A small change is also required to libunwind or libdw depending on which
> unwinder is used, and these will be published later. Without these changes Perf
> continues to work with both libraries, although the VG register is still not
> used for unwinding. 

Thanks, applied.

- Arnaldo

 
> Thanks
> James
> 
> James Clark (5):
>   perf tools: arm64: Use perf's copy of kernel headers
>   perf tools: arm64: Copy perf_regs.h from the kernel
>   perf tools: Use dynamic register set for Dwarf unwind
>   perf tools: arm64: Decouple Libunwind register names from Perf
>   perf tools: arm64: Add support for VG register
> 
>  tools/arch/arm64/include/uapi/asm/perf_regs.h |  7 +-
>  tools/perf/arch/arm64/util/perf_regs.c        | 34 +++++++++
>  tools/perf/arch/arm64/util/unwind-libunwind.c | 73 +------------------
>  tools/perf/util/evsel.c                       |  2 +-
>  tools/perf/util/libunwind/arm64.c             |  2 +-
>  tools/perf/util/perf_regs.c                   |  2 +
>  6 files changed, 46 insertions(+), 74 deletions(-)
> 
> -- 
> 2.28.0

-- 

- Arnaldo

  parent reply	other threads:[~2022-05-26 15:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 15:41 [PATCH v3 0/5] perf: arm64: Tools support for Dwarf unwinding through SVE functions James Clark
2022-05-25 15:41 ` [PATCH v3 1/5] perf tools: arm64: Use perf's copy of kernel headers James Clark
2022-05-25 15:59   ` German Gomez
2022-06-02 18:08     ` Ian Rogers
2022-05-25 15:41 ` [PATCH v3 2/5] perf tools: arm64: Copy perf_regs.h from the kernel James Clark
2022-05-25 15:41 ` [PATCH v3 3/5] perf tools: Use dynamic register set for Dwarf unwind James Clark
2022-05-25 15:41 ` [PATCH v3 4/5] perf tools: arm64: Decouple Libunwind register names from Perf James Clark
2022-05-25 15:41 ` [PATCH v3 5/5] perf tools: arm64: Add support for VG register James Clark
2022-05-26 15:23 ` Arnaldo Carvalho de Melo [this message]
2022-09-23 10:34   ` [PATCH v3 0/5] perf: arm64: Tools support for Dwarf unwinding through SVE functions James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yo+bdSMUOkd1N4HE@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=german.gomez@arm.com \
    --cc=james.clark@arm.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).