From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F636C433F5 for ; Tue, 17 May 2022 15:03:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245663AbiEQPDT (ORCPT ); Tue, 17 May 2022 11:03:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243507AbiEQPDR (ORCPT ); Tue, 17 May 2022 11:03:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98BF96410; Tue, 17 May 2022 08:03:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DBECDB818FF; Tue, 17 May 2022 15:03:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 630F4C385B8; Tue, 17 May 2022 15:03:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652799793; bh=byrQErYFQlhTfmVu1YurdHSZ08z5LZgcXvlnYcs4SNQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PfOhPDT8JZh+i0Zzmvh43u+bFH15pqQHxC336x4IG8IhA0fOYeHf7sozb4ZDErIe4 +BuRy6sTNNOHxYJAJJP/LF6A6UqAPJxrmZxVSmV5EoQpTLODj+ITlUA0yS9YOPcuUF vEcEEQlHoIxpS/HGtKxEILNFjDVjqYYaweWKzVg7yQMb/vE7lMhuYl+ehVfAi/gkaH T+LWH1Ze8q2tUdEGk41szWe12+t9IMlcBTxH75eEMAZTm8NO76MIdiko3l0yGiPAb4 jXkliKItJblCTFEjnuPzGqGca7eZMhXtIniJZKFv9uBhhYKAPdNkKgWX7Rd4yat+rc MiiVMevf0KThA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 07C8F400B1; Tue, 17 May 2022 12:03:10 -0300 (-03) Date: Tue, 17 May 2022 12:03:10 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Riccardo Mancini , Kim Phillips , Madhavan Srinivasan , Shunsuke Nakamura , Florian Fischer , Andi Kleen , John Garry , Zhengjun Xing , Adrian Hunter , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH v3 0/2] Fix topdown event weak grouping Message-ID: References: <20220517052724.283874-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517052724.283874-1-irogers@google.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, May 16, 2022 at 10:27:22PM -0700, Ian Rogers escreveu: > Keep topdown events within a group when a weak group is broken. This > is a requirement as topdown events must form a group. > > Add perf stat testing including for required topdown event group > behaviors. > > Note: as with existing topdown evsel/evlist code topdown events are > assumed to be on the PMU "cpu". On Alderlake the PMU "cpu_core" should > also be tested. Future changes can fix Alderlake. Thanks, applied. - Arnaldo > v3. Fix computation of number of events in leader's group. > Adds reviewed-by: Liang, Kan v2. Correct behavior wrt pmu prefixed events and avoid the test using > deprecated events: Suggested-by: Liang, Kan > > Ian Rogers (2): > perf evlist: Keep topdown counters in weak group > perf test: Add basic stat and topdown group test > > tools/perf/arch/x86/util/evsel.c | 12 ++++++ > tools/perf/tests/shell/stat.sh | 67 ++++++++++++++++++++++++++++++++ > tools/perf/util/evlist.c | 16 +++++++- > tools/perf/util/evsel.c | 10 +++++ > tools/perf/util/evsel.h | 3 ++ > 5 files changed, 106 insertions(+), 2 deletions(-) > create mode 100755 tools/perf/tests/shell/stat.sh > > -- > 2.36.0.550.gb090851708-goog -- - Arnaldo