From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA1DC433F5 for ; Mon, 23 May 2022 13:09:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235912AbiEWNJb (ORCPT ); Mon, 23 May 2022 09:09:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235887AbiEWNJ3 (ORCPT ); Mon, 23 May 2022 09:09:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF3DC54000; Mon, 23 May 2022 06:09:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5AF6B61344; Mon, 23 May 2022 13:09:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CB32C385A9; Mon, 23 May 2022 13:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653311367; bh=3FWqQ6lBRWaRCCFb2djCRRQ4eov10UfYPZz+vcD4rls=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sfjc23tz95+FUSHH8zPfCLpqGyoFaRPCfbuuAVakgWe+s3p+/yVaWqpy/mHbYy+F8 Tu2glSAybK4lv9UeXxP7LZzz9NhMKpldc9mr2ZJJE4zVuAOceUfsnYtkT02FCZ5sbm eSL1/dYGXVMxd5BtuzMFgHNw/bRLTfCEbwferc2rQZJ9lKpT4hbYzQXgG4e6TFFtpy x6PjMA+z2A4lFzePSCOegfdBtcYPYEArpJi0iSvA8JFyoabx3hcn3KSNZG+8HTGjo8 dncUSC6FiaSXMJzp3La3+1yFg/MiTV+pHNaquXcuoYwgVfIcVP9AEZMCr3JQHKUDZX mLCLBJT8DGcAw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 7FC38400B1; Mon, 23 May 2022 10:09:25 -0300 (-03) Date: Mon, 23 May 2022 10:09:25 -0300 From: Arnaldo Carvalho de Melo To: John Garry Cc: Ian Rogers , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kan Liang , Andi Kleen , Zhengjun Xing , Felix Fietkau , Qi Liu , Like Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Nick Forrington , Kajol Jain , James Clark , Andrew Kilroy , "Paul A . Clarke" , Will Deacon , Mathieu Poirier , ananth.narayan@amd.com, ravi.bangoria@amd.com, santosh.shukla@amd.com, sandipan.das@amd.com, Caleb Biggers , Perry Taylor , Kshipra Bopardikar , Stephane Eranian Subject: Re: [PATCH v2 4/7] perf jevents: Modify match field Message-ID: References: <20220511211526.1021908-1-irogers@google.com> <20220511211526.1021908-5-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Tue, May 17, 2022 at 02:35:14PM +0100, John Garry escreveu: > On 11/05/2022 22:15, Ian Rogers wrote: > > The match_field function looks for json values to append to the event > > string. As the C code processes these in order the output order matches > > that in the json dictionary. Python json readers read the entire > > dictionary and lose the ordering. To make the python and C output > > comparable make the C code first read the extra fields then append them > > to the event in an order not determined by their order in the file. > > > > Modify the pmu-events test so that test expectations match the new > > order. > > > > Signed-off-by: Ian Rogers > > Reviewed-by: John Garry Applied up to here, will take a closer look at 5-7 - Arnaldo