From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: namhyung@kernel.org, kan.liang@linux.intel.com, jolsa@kernel.org,
irogers@google.com, peterz@infradead.org, rrichter@amd.com,
mingo@redhat.com, mark.rutland@arm.com, tglx@linutronix.de,
bp@alien8.de, james.clark@arm.com, leo.yan@linaro.org,
ak@linux.intel.com, eranian@google.com, like.xu.linux@gmail.com,
x86@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, sandipan.das@amd.com,
ananth.narayan@amd.com, kim.phillips@amd.com,
santosh.shukla@amd.com
Subject: Re: [PATCH v5 1/8] perf record ibs: Warn about sampling period skew
Date: Fri, 3 Jun 2022 21:25:46 +0200 [thread overview]
Message-ID: <YppgOuFXzaTmCsmY@kernel.org> (raw)
In-Reply-To: <76f02f9c-139b-f26b-0cc6-6edc486f5244@amd.com>
Em Fri, Jun 03, 2022 at 10:58:13AM +0530, Ravi Bangoria escreveu:
> On 03-Jun-22 10:42 AM, Ravi Bangoria wrote:
> >>> + if (ibs_fetch_pmu && ibs_fetch_pmu->type == evsel_pmu->type) {
> >>> + if (attr->config & (1ULL << 59)) {
> >>
> >> It'd be nice if we used a macro or something instead of the
> >> magic number.
> >>
> >>> + ibs_l3miss_warn();
> >>> + warned_once = 1;
> >>> + }
> >>> + } else if (ibs_op_pmu && ibs_op_pmu->type == evsel_pmu->type) {
> >>> + if (attr->config & (1ULL << 16)) {
> >>
> >> Ditto.
> >
> > Thanks for the review, Namhyung.
> >
> > Arnaldo, Would you be able to squash below trivial patch into original
> > patch? Please let me know if you want me to respin the series instead.
>
> I'm planning to respin with asprintf() change. Sorry for the noise.
Ok, will wait for the respin then.
- Arnaldo
next prev parent reply other threads:[~2022-06-03 19:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 3:26 [PATCH v5 0/8] perf/amd: Zen4 IBS extensions support (tool changes) Ravi Bangoria
2022-06-01 3:26 ` [PATCH v5 1/8] perf record ibs: Warn about sampling period skew Ravi Bangoria
2022-06-02 20:30 ` Namhyung Kim
2022-06-03 5:12 ` Ravi Bangoria
2022-06-03 5:28 ` Ravi Bangoria
2022-06-03 19:25 ` Arnaldo Carvalho de Melo [this message]
2022-06-01 3:26 ` [PATCH v5 2/8] perf tool: Parse pmu caps sysfs only once Ravi Bangoria
2022-06-01 13:35 ` Liang, Kan
2022-06-01 13:51 ` Ravi Bangoria
2022-06-01 13:55 ` Liang, Kan
2022-06-01 3:26 ` [PATCH v5 3/8] perf headers: Pass "cpu" pmu name while printing caps Ravi Bangoria
2022-06-01 13:35 ` Liang, Kan
2022-06-01 3:26 ` [PATCH v5 4/8] perf headers: Store pmu caps in an array of strings Ravi Bangoria
2022-06-01 13:36 ` Liang, Kan
2022-06-02 21:37 ` Namhyung Kim
2022-06-03 5:20 ` Ravi Bangoria
2022-06-01 3:26 ` [PATCH v5 5/8] perf headers: Record non-cpu pmu capabilities Ravi Bangoria
2022-06-01 13:37 ` Liang, Kan
2022-06-01 13:58 ` Liang, Kan
2022-06-01 3:26 ` [PATCH v5 6/8] perf/x86/ibs: Add new IBS register bits into header Ravi Bangoria
2022-06-02 21:48 ` Namhyung Kim
2022-06-03 5:24 ` Ravi Bangoria
2022-06-01 3:26 ` [PATCH v5 7/8] perf tool ibs: Sync amd ibs header file Ravi Bangoria
2022-06-01 3:26 ` [PATCH v5 8/8] perf script ibs: Support new IBS bits in raw trace dump Ravi Bangoria
2022-06-01 14:04 ` [PATCH v5 0/8] perf/amd: Zen4 IBS extensions support (tool changes) Liang, Kan
2022-06-01 14:10 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YppgOuFXzaTmCsmY@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=leo.yan@linaro.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=rrichter@amd.com \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).