From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E353C00144 for ; Mon, 1 Aug 2022 17:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234107AbiHAR6E (ORCPT ); Mon, 1 Aug 2022 13:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234139AbiHAR5c (ORCPT ); Mon, 1 Aug 2022 13:57:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55738B1DC; Mon, 1 Aug 2022 10:56:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BFF1561160; Mon, 1 Aug 2022 17:56:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2A0BC433C1; Mon, 1 Aug 2022 17:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659376583; bh=sgF7Ila5Go50G/Z0YwLeetdlAZaIQSPpQ4eGRIrjUfQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eQTYpYq2X9p4/bUFs31elGwHf3bxE9a0XO/ulP0WVFoHMvP3pBDsTMQejLTPyc2N3 U0fHcZyyUzs/hhoGl63QeTyCgHAAWQZe5PVcW3pUX6PHoCVWvrN7qmCR175zqC2h5i 6yEdsEwEqFKRGuM4hKs3bzMgYHLh3cS7AmlMpItHucbTG+v8TztGV6kKSsW1wrdAoz jDJBZwDTV9oi3kQt+hKPYgo9brBELv4brGpE+pT9HyEmJI2p/7/4DShfeKyk/IagAY VirBQTb9SHpfzfBi8+biYsCRl6uS+abxZJMAkSqhtHs9YjBiHqk5FiyIi0wd7aKtOp VqQoQ40Kai+IA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 5DE0940736; Mon, 1 Aug 2022 14:56:20 -0300 (-03) Date: Mon, 1 Aug 2022 14:56:20 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ian Rogers , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users , LKML , Stephane Eranian Subject: Re: [PATCH] perf symbol: Fail to read phdr workaround Message-ID: References: <20220731164923.691193-1-irogers@google.com> <20220801015259.GA101027@leoy-ThinkPad-X240s> <20220801132511.GC73228@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220801132511.GC73228@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Aug 01, 2022 at 09:25:11PM +0800, Leo Yan escreveu: > On Mon, Aug 01, 2022 at 09:38:23AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Sun, Jul 31, 2022 at 11:19:15PM -0700, Ian Rogers escreveu: > > > On Sun, Jul 31, 2022, 6:53 PM Leo Yan wrote: > > > > > > > On Sun, Jul 31, 2022 at 09:49:23AM -0700, Ian Rogers wrote: > > > > > The perf jvmti agent doesn't create program headers, in this case > > > > > fallback on section headers as happened previously. > > > > > > > > > > Fixes: 882528d2e776 ("perf symbol: Skip symbols if SHF_ALLOC flag is not > > > > set") > > > > > > > > It's good to change fix tag as: > > > > Fixes: 2d86612aacb7 ("perf symbol: Correct address for bss symbols") > > > > > > > > > > Doh! I was rushing this morning. Thanks for catching and reviewing! > > > > I made the adjustments and added a note with the repro, to help in the > > future when trying to test this area. > > Thanks, Arnaldo. > > > I also think we could have something like a 'perf test' mode where, when > > asked to, it would enable tests that involve downloading such files to > > perform tests, such as this dacapo benchmark, and then would test if the > > output matches expectations. > > I will add a testing based on the steps, alongside with the discussed > testing for data symbols. Will share out after get ready. Great! Thanks in advance, - Arnaldo