From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Brian Robbins <brianrob@linux.microsoft.com>,
Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf inject jit: Ignore memfd mmap events if jitdump present
Date: Wed, 10 Aug 2022 10:03:17 -0300 [thread overview]
Message-ID: <YvOslWVtSyHRJAOw@kernel.org> (raw)
In-Reply-To: <YvOr3t9JNlEI4p+6@kernel.org>
Em Wed, Aug 10, 2022 at 10:00:14AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Aug 04, 2022 at 08:22:14AM -0700, Ian Rogers escreveu:
> > On Tue, Aug 2, 2022 at 11:25 AM Brian Robbins <brianrob@linux.microsoft.com> wrote:
> > > Signed-off-by: Brian Robbins <brianrob@linux.microsoft.com>
> >
> > Acked-by: Ian Rogers <irogers@google.com>
>
> CC /tmp/build/perf/util/jitdump.o
> CC /tmp/build/perf/pmu-events/pmu-events.o
> LD /tmp/build/perf/pmu-events/pmu-events-in.o
> util/jitdump.c: In function ‘jit_process’:
> util/jitdump.c:853:65: error: expected ‘)’ before ‘return’
> 853 | (strncmp(filename, "/memfd:", 7) == 0))
> | ^
> | )
> 854 | return 1;
> | ~~~~~~
> util/jitdump.c:851:20: note: to match this ‘(’
> 851 | if (jit_has_pid(machine, pid) &&
> | ^
> util/jitdump.c:857:9: error: expected expression before ‘}’ token
> 857 | }
> | ^
> make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/util/jitdump.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> make[3]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:139: util] Error 2
>
>
> Trying to fix now.
Trivial, please compile test it...
- Arnaldo
diff --git a/tools/perf/util/jitdump.c b/tools/perf/util/jitdump.c
index 335a3c61940b7b39..9983d21a5c42d70e 100644
--- a/tools/perf/util/jitdump.c
+++ b/tools/perf/util/jitdump.c
@@ -850,7 +850,7 @@ jit_process(struct perf_session *session,
*/
if (jit_has_pid(machine, pid) &&
((strncmp(filename, "//anon", 6) == 0) ||
- (strncmp(filename, "/memfd:", 7) == 0))
+ (strncmp(filename, "/memfd:", 7) == 0)))
return 1;
return 0;
next prev parent reply other threads:[~2022-08-10 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 18:25 [PATCH] perf inject jit: Ignore memfd mmap events if jitdump present Brian Robbins
2022-08-04 15:22 ` Ian Rogers
2022-08-04 17:51 ` Brian Robbins
2022-08-10 13:00 ` Arnaldo Carvalho de Melo
2022-08-10 13:03 ` Arnaldo Carvalho de Melo [this message]
2022-08-10 15:08 ` Brian Robbins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvOslWVtSyHRJAOw@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=brianrob@linux.microsoft.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).