From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Kajol Jain <kjain@linux.ibm.com>, Ali Saidi <alisaidi@amazon.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Ian Rogers <irogers@google.com>, Like Xu <likexu@tencent.com>,
German Gomez <german.gomez@arm.com>,
Timothy Hayes <timothy.hayes@arm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 01/15] perf tools: sync addition of PERF_MEM_SNOOPX_PEER
Date: Thu, 11 Aug 2022 18:55:48 -0300 [thread overview]
Message-ID: <YvV65OewRk9YJP5K@kernel.org> (raw)
In-Reply-To: <20220811062451.435810-2-leo.yan@linaro.org>
Em Thu, Aug 11, 2022 at 02:24:37PM +0800, Leo Yan escreveu:
> From: Ali Saidi <alisaidi@amazon.com>
>
> Add a flag to the perf mem data struct to signal that a request caused a
> cache-to-cache transfer of a line from a peer of the requestor and
> wasn't sourced from a lower cache level. The line being moved from one
> peer cache to another has latency and performance implications. On Arm64
> Neoverse systems the data source can indicate a cache-to-cache transfer
> but not if the line is dirty or clean, so instead of overloading HITM
> define a new flag that indicates this type of transfer.
>
> Signed-off-by: Ali Saidi <alisaidi@amazon.com>
> Reviewed-by: Leo Yan <leo.yan@linaro.org>
I'm adding a:
Signed-off-by: Leo Yan <leo.yan@linaro.org>
To the patches you're sending that you are not the original author, as
per defined in:
Documentation/process/submitting-patches.rst
---
The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path.
---
If you disagree and want to retract the patch, please let me know, this
so far is speculative and is only on my local branch for testing.
- Arnaldo
> ---
> tools/include/uapi/linux/perf_event.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h
> index 4653834f078f..e2b77fbca91e 100644
> --- a/tools/include/uapi/linux/perf_event.h
> +++ b/tools/include/uapi/linux/perf_event.h
> @@ -1310,7 +1310,7 @@ union perf_mem_data_src {
> #define PERF_MEM_SNOOP_SHIFT 19
>
> #define PERF_MEM_SNOOPX_FWD 0x01 /* forward */
> -/* 1 free */
> +#define PERF_MEM_SNOOPX_PEER 0x02 /* xfer from peer */
> #define PERF_MEM_SNOOPX_SHIFT 38
>
> /* locked instruction */
> --
> 2.34.1
--
- Arnaldo
next prev parent reply other threads:[~2022-08-11 21:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 6:24 [PATCH v6 00/15] perf c2c: Support data source and display for Arm64 Leo Yan
2022-08-11 6:24 ` [PATCH v6 01/15] perf tools: sync addition of PERF_MEM_SNOOPX_PEER Leo Yan
2022-08-11 21:55 ` Arnaldo Carvalho de Melo [this message]
2022-08-11 6:24 ` [PATCH v6 02/15] perf mem: Print snoop peer flag Leo Yan
2022-08-11 6:24 ` [PATCH v6 03/15] perf arm-spe: Use SPE data source for neoverse cores Leo Yan
2022-08-11 22:01 ` Arnaldo Carvalho de Melo
2022-08-11 6:24 ` [PATCH v6 04/15] perf mem: Add statistics for peer snooping Leo Yan
2022-08-11 6:24 ` [PATCH v6 05/15] perf c2c: Output " Leo Yan
2022-08-11 6:24 ` [PATCH v6 06/15] perf c2c: Add dimensions for peer load operations Leo Yan
2022-08-11 6:24 ` [PATCH v6 07/15] perf c2c: Add dimensions of peer metrics for cache line view Leo Yan
2022-08-11 6:24 ` [PATCH v6 08/15] perf c2c: Add mean dimensions for peer operations Leo Yan
2022-08-11 6:24 ` [PATCH v6 09/15] perf c2c: Use explicit names for display macros Leo Yan
2022-08-11 6:24 ` [PATCH v6 10/15] perf c2c: Rename dimension from 'percent_hitm' to 'percent_costly_snoop' Leo Yan
2022-08-11 6:24 ` [PATCH v6 11/15] perf c2c: Refactor node header Leo Yan
2022-08-11 6:24 ` [PATCH v6 12/15] perf c2c: Refactor display string Leo Yan
2022-08-11 6:24 ` [PATCH v6 13/15] perf c2c: Sort on peer snooping for load operations Leo Yan
2022-08-11 6:24 ` [PATCH v6 14/15] perf c2c: Use 'peer' as default display for Arm64 Leo Yan
2022-08-11 6:24 ` [PATCH v6 15/15] perf c2c: Update documentation for new display option 'peer' Leo Yan
2022-08-11 22:25 ` [PATCH v6 00/15] perf c2c: Support data source and display for Arm64 Arnaldo Carvalho de Melo
2022-08-12 1:26 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvV65OewRk9YJP5K@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alisaidi@amazon.com \
--cc=anshuman.khandual@arm.com \
--cc=german.gomez@arm.com \
--cc=gustavoars@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=likexu@tencent.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=timothy.hayes@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).