From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B417CC25B07 for ; Thu, 11 Aug 2022 21:56:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236044AbiHKV4F (ORCPT ); Thu, 11 Aug 2022 17:56:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235897AbiHKVz4 (ORCPT ); Thu, 11 Aug 2022 17:55:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E04A322B0E; Thu, 11 Aug 2022 14:55:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9AEDEB822B6; Thu, 11 Aug 2022 21:55:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35ACBC433C1; Thu, 11 Aug 2022 21:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660254951; bh=kTbxGObabGQ7EanYHkFw676cjQFD3rZRIfyyXUv4DWo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DqD1Xrg7/BnTj/0gIoVbtBcyyD7xzqTatQSOW8qrfDeT/viTgx5yctdUMm/mdQNDA E4YJv5TFZbsm1NBvJV3E0eMf9kPuWMfoULBdHKbu/denOGcmYl3oQxEhJPDTwuM+SS OWC6GSM2Hw8Knzyxw7M64gxwdtBh7HI7EcUdn41rdRPvmuTU0NnszvQQjkFGSTZMCy gYRNS6q/Gsikik35+jdfWiTiklYILURPRkKJcbiRAae3OcknoDDf/WANavpj2DZfxC jWC8aeggaF5/FpGQQl8/X14/dZLNAa78pFzoi5hUp2kuibFuA4APm0zeOKs57HQs3X paUX28BzZARzg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 1455A4035A; Thu, 11 Aug 2022 18:55:48 -0300 (-03) Date: Thu, 11 Aug 2022 18:55:48 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , James Clark , Mike Leach , Kajol Jain , Ali Saidi , Adrian Hunter , "Gustavo A. R. Silva" , Anshuman Khandual , Ian Rogers , Like Xu , German Gomez , Timothy Hayes , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 01/15] perf tools: sync addition of PERF_MEM_SNOOPX_PEER Message-ID: References: <20220811062451.435810-1-leo.yan@linaro.org> <20220811062451.435810-2-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220811062451.435810-2-leo.yan@linaro.org> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Thu, Aug 11, 2022 at 02:24:37PM +0800, Leo Yan escreveu: > From: Ali Saidi > > Add a flag to the perf mem data struct to signal that a request caused a > cache-to-cache transfer of a line from a peer of the requestor and > wasn't sourced from a lower cache level. The line being moved from one > peer cache to another has latency and performance implications. On Arm64 > Neoverse systems the data source can indicate a cache-to-cache transfer > but not if the line is dirty or clean, so instead of overloading HITM > define a new flag that indicates this type of transfer. > > Signed-off-by: Ali Saidi > Reviewed-by: Leo Yan I'm adding a: Signed-off-by: Leo Yan To the patches you're sending that you are not the original author, as per defined in: Documentation/process/submitting-patches.rst --- The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. --- If you disagree and want to retract the patch, please let me know, this so far is speculative and is only on my local branch for testing. - Arnaldo > --- > tools/include/uapi/linux/perf_event.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h > index 4653834f078f..e2b77fbca91e 100644 > --- a/tools/include/uapi/linux/perf_event.h > +++ b/tools/include/uapi/linux/perf_event.h > @@ -1310,7 +1310,7 @@ union perf_mem_data_src { > #define PERF_MEM_SNOOP_SHIFT 19 > > #define PERF_MEM_SNOOPX_FWD 0x01 /* forward */ > -/* 1 free */ > +#define PERF_MEM_SNOOPX_PEER 0x02 /* xfer from peer */ > #define PERF_MEM_SNOOPX_SHIFT 38 > > /* locked instruction */ > -- > 2.34.1 -- - Arnaldo