From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Yang Li <yang.lee@linux.alibaba.com>,
peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] perf stat: Remove duplicated include in builtin-stat.c
Date: Fri, 12 Aug 2022 16:52:09 -0300 [thread overview]
Message-ID: <YvavaYuhZ/VDGG7Z@kernel.org> (raw)
In-Reply-To: <CAP-5=fX_2sfYOa+4=28-JKfYoTg9wG3i8MRkGvqc3fLE1R=qYQ@mail.gmail.com>
Em Thu, Aug 04, 2022 at 08:32:22AM -0700, Ian Rogers escreveu:
> On Wed, Aug 3, 2022 at 5:52 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
> >
> > util/topdown.h is included twice in builtin-stat.c,
> > remove one of them.
> >
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1818
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> Tested-by: Ian Rogers <irogers@google.com>
Thanks, applied.
- Arnaldo
> Thanks,
> Ian
>
> > ---
> > tools/perf/builtin-stat.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> > index 3d22543fc305..e326226656e4 100644
> > --- a/tools/perf/builtin-stat.c
> > +++ b/tools/perf/builtin-stat.c
> > @@ -71,7 +71,6 @@
> > #include "util/bpf_counter.h"
> > #include "util/iostat.h"
> > #include "util/pmu-hybrid.h"
> > - #include "util/topdown.h"
> > #include "asm/bug.h"
> >
> > #include <linux/time64.h>
> > --
> > 2.20.1.7.g153144c
> >
--
- Arnaldo
prev parent reply other threads:[~2022-08-12 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 0:52 [PATCH -next] perf stat: Remove duplicated include in builtin-stat.c Yang Li
2022-08-04 15:32 ` Ian Rogers
2022-08-12 19:52 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvavaYuhZ/VDGG7Z@kernel.org \
--to=acme@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).