Re: Cannot print 'uregs' field with perf script -F uregs

[Jiri Olsa <olsajiri@gmail.com>]

On Mon, Aug 15, 2022 at 04:22:57AM +0000, Hongtao Yu wrote:
> Hi,
>  
> I was seeing an issue with “perf script -F uregs”: 
>  
> Samples for 'dummy:HG' event do not have UREGS attribute set. Cannot print 'uregs' field.
>  
> This seems to only happen to a perf.data resulted from a system-wide monitoring, e.g “perf record -a”. Per-process monitoring works fine. By search up online I see a thread that could be relevant:   https://lore.kernel.org/all/YVNq9av%2F3Lwmom4T@krava/
>  
> Can someone please shed a light whether this is an issue with perf, or something wrong with my perf.data?
>  
>  
> Thanks,
> Hongtao
>  
>  


hum, I thought we already fixed this.. would fix below work for you?

thanks,
jirka


---
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 13580a9c50b8..30c9cbdee98d 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -451,6 +451,9 @@ static int evsel__check_attr(struct evsel *evsel, struct perf_session *session)
 	allow_user_set = perf_header__has_feat(&session->header,
 					       HEADER_AUXTRACE);
 
+	if (evsel__is_dummy_event(evsel))
+		allow_user_set = true;
+
 	if (PRINT_FIELD(TRACE) &&
 	    !perf_session__has_traces(session, "record -R"))
 		return -EINVAL;
@@ -517,7 +520,7 @@ static int evsel__check_attr(struct evsel *evsel, struct perf_session *session)
 		return -EINVAL;
 
 	if (PRINT_FIELD(UREGS) &&
-	    evsel__check_stype(evsel, PERF_SAMPLE_REGS_USER, "UREGS", PERF_OUTPUT_UREGS))
+	    evsel__do_check_stype(evsel, PERF_SAMPLE_REGS_USER, "UREGS", PERF_OUTPUT_UREGS, allow_user_set))
 		return -EINVAL;
 
 	if (PRINT_FIELD(PHYS_ADDR) &&