From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13AC9C2BB41 for ; Tue, 16 Aug 2022 19:55:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237289AbiHPTzB (ORCPT ); Tue, 16 Aug 2022 15:55:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231804AbiHPTzA (ORCPT ); Tue, 16 Aug 2022 15:55:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C101079605; Tue, 16 Aug 2022 12:54:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6F401B81AA7; Tue, 16 Aug 2022 19:54:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 062A5C433C1; Tue, 16 Aug 2022 19:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660679696; bh=Dv9W8QLz1LA4YHxnAf2g5KmnoAlkZPcjgdcUZXnkJ7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zxa3et2Ds6fZ4gNaGeT5SnNiZhDx/03Dp18FAiPcxu4jBGmUXjCpCL/VdIEu1buoJ xkOQwdJyLE/IfU3XopgKNWO7pDwx98YVRR3jZ2vE1b80hA5aLLo9KhlXa4Ivb/zE2C l9oDjVZARL+Ytf9X5closp4eioEzS1UYA/vwr9NbxK9637BUAIjtbTrXVSzqR+3063 pyHuYfBg9QOsOdRnN+V35k7mYLgm5b2SqaFThxoZd0Ns5IVuqqeIECBE5l1IOKJzUH +X6f/O3R0t0pmh5bRTVysqk7+KvNfIfsFdbdKR3oChuYnZzbTa3CRvc1JocpsYJsfL Q31Hg/2b7E1xQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 583544035A; Tue, 16 Aug 2022 16:54:53 -0300 (-03) Date: Tue, 16 Aug 2022 16:54:53 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Raul Silvera , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , James Clark , linux-perf-users , linux-kernel Subject: Re: [PATCH v4] perf inject: Add a command line option to specify build ids. Message-ID: References: <20220815225922.2118745-1-rsilvera@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Aug 15, 2022 at 10:11:41PM -0700, Namhyung Kim escreveu: > Hello, > > On Mon, Aug 15, 2022 at 3:59 PM Raul Silvera wrote: > > > > This commit adds the option --known-build-ids to perf inject. > > It allows the user to explicitly specify the build id for a given > > path, instead of retrieving it from the current system. This is > > useful in cases where a perf.data file is processed on a different > > system from where it was collected, or if some of the binaries are > > no longer available. > > > > The build ids and paths are specified in pairs in the command line. > > Using the file:// specifier, build ids can be loaded from a file > > directly generated by perf buildid-list. This is convenient to copy > > build ids from one perf.data file to another. > > > > ** Example: In this example we use perf record to create two > > perf.data files, one with build ids and another without, and use > > perf buildid-list and perf inject to copy the build ids from the > > first file to the second. > > > > $ perf record ls /tmp > > $ perf record --no-buildid -o perf.data.no-buildid ls /tmp > > $ perf buildid-list > build-ids.txt > > $ perf inject -b --known-build-ids='file://build-ids.txt' \ > > -i perf.data.no-buildid -o perf.data.buildid > > > > Signed-off-by: Raul Silvera > > Acked-by: Namhyung Kim Thanks, applied to perf/core. - Arnaldo