From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7EB6ECAAD4 for ; Wed, 31 Aug 2022 19:54:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232078AbiHaTyO (ORCPT ); Wed, 31 Aug 2022 15:54:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229609AbiHaTyO (ORCPT ); Wed, 31 Aug 2022 15:54:14 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A723EE69A for ; Wed, 31 Aug 2022 12:54:13 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id v5so8889811plo.9 for ; Wed, 31 Aug 2022 12:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=i1fxz0Si79I0x6/Tol+AeOK8ljyJ1ydzgNsYRl83dw4=; b=nz4DrZ4pPGU/omZF1St7jI238P/OlFOfl94ByncU9Q1XJe4fKq9DtBBK2Sq97vu8Az Wy2vuPn1ekSvIdK+TqIUjuM4H111kod4RumfP2bxqhwbvAgrYp0Csy6hrXdsqe1ze5ja sE70n2wdT8pLG5wc64en7JUGFXmh/L4+s/zp4b5+VGXjCF+/BI/ypSC82egUpXaAn9Xo TBAHDEX4mZtDFi+KC1q1/klBQxwUdWreLeiuuPkdl3gzMt4vioCNhdoZX6fOEG4ZxRCz 6QNfaEOXmYsyMDzYdQbhDqrAaWfev6wQvPa7BG88mGP56uIYjybyaUDVxwQ8rMS/RO6V XxYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=i1fxz0Si79I0x6/Tol+AeOK8ljyJ1ydzgNsYRl83dw4=; b=dSf5hE2FZ0BPmBpYJzLf13sSKX2axI0uJWSDBlNs9fm2rXIpIjNY5uWS250fHTNOlJ zcHjK06O9sziGES590zRUgB4FPA/9kypiMXo6PDBaRKPYsemvnsd3MvKFdNUg6jkmRbg haWZdK7GB1rcHAuIih/K5Hdl32ZWycbhIcFesgQG76HW23z/E6qgWwA3ckmQjrUkLftI bJmFpjuT6rBDSTt/m6CgeF26Wv2HMsIMj7qPhFZ/ON1B6ezCqTFsxX/UZq/6U7t/+qkw qidtJraIgFUwzu835svY5xAy2nVfIvwVi6325S6X8sFKWmAv1e49tiRpZwYOPcXwQQKJ xQ1A== X-Gm-Message-State: ACgBeo2RQa2OJ1TKa9KAUsxq5CkhEJ8bdieMeJxm8PqAcvkVq5/RxgEu 9mH6ttsl8uJXXvKQd4XtSYMJ6A== X-Google-Smtp-Source: AA6agR794xW6Z+MfG5Ib9/crU2BZBN5/rJBCdOsohFLApMk8X0TGCCHkHKAvwd3Y9PrLWVE0a3cZtA== X-Received: by 2002:a17:902:e841:b0:174:9605:e96a with SMTP id t1-20020a170902e84100b001749605e96amr18478841plg.108.1661975652680; Wed, 31 Aug 2022 12:54:12 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id mn22-20020a17090b189600b001fd7cde9990sm1771283pjb.0.2022.08.31.12.54.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 12:54:12 -0700 (PDT) Date: Wed, 31 Aug 2022 19:54:08 +0000 From: Sean Christopherson To: kernel test robot Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Paolo Bonzini , kbuild-all@lists.01.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Like Xu Subject: Re: [PATCH v3 3/3] KVM: VMX: Advertise PMU LBRs if and only if perf supports LBRs Message-ID: References: <20220831000051.4015031-4-seanjc@google.com> <202208311831.zQ4oCG1b-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202208311831.zQ4oCG1b-lkp@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Wed, Aug 31, 2022, kernel test robot wrote: > Hi Sean, > > I love your patch! Yet something to improve: > > [auto build test ERROR on 372d07084593dc7a399bf9bee815711b1fb1bcf2] > > url: https://github.com/intel-lab-lkp/linux/commits/Sean-Christopherson/KVM-x86-Intel-LBR-related-perf-cleanups/20220831-080309 > base: 372d07084593dc7a399bf9bee815711b1fb1bcf2 > config: i386-randconfig-s001 (https://download.01.org/0day-ci/archive/20220831/202208311831.zQ4oCG1b-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.4-39-gce1a6720-dirty > # https://github.com/intel-lab-lkp/linux/commit/094f42374997562fff3f9f9637ec9aa8257490a0 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Sean-Christopherson/KVM-x86-Intel-LBR-related-perf-cleanups/20220831-080309 > git checkout 094f42374997562fff3f9f9637ec9aa8257490a0 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 prepare > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > In file included from arch/x86/kernel/../kvm/vmx/vmx.h:11, > from arch/x86/kernel/asm-offsets.c:22: Argh, KVM's "internal" vmx.h gets included by arch/x86/kernel/asm-offsets.c even when KVM is disabled, and vmx_get_perf_capabilities() is oddly inlined there. The simple fix is to move the definition of vmx_get_perf_capabilities() into vmx.c. Long term, I want to figure out a way to break the dependency on asm-offsets. I ran afoul of this a week ago for something else, but couldn't figure an easy solution and it wasn't (yet) a blocking issue.