From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Hongtao Yu <hoy@fb.com>,
Namhyung Kim <namhyung@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf script: Skip dummy event attr check
Date: Wed, 31 Aug 2022 13:23:36 -0300 [thread overview]
Message-ID: <Yw+LCN2cX9peweWV@kernel.org> (raw)
In-Reply-To: <CAP-5=fX-=ph8g3VKbQXSRT8SiOZ3XqQLd3T9-ZTNZ5L+ye5L-A@mail.gmail.com>
Em Wed, Aug 31, 2022 at 09:02:46AM -0700, Ian Rogers escreveu:
> On Wed, Aug 31, 2022 at 5:40 AM Jiri Olsa <jolsa@kernel.org> wrote:
> >
> > Hongtao Yu reported problem when displaying uregs in perf script
> > for system wide perf.data:
> >
> > # perf script -F uregs | head -10
> > Samples for 'dummy:HG' event do not have UREGS attribute set. Cannot print 'uregs' field.
> >
> > The problem is the extra dummy event added for system wide,
> > which does not have proper sample_type setup.
> >
> > Skipping attr check completely for dummy event as suggested
> > by Namhyung, because it does not have any samples anyway.
> >
> > Reported-by: Hongtao Yu <hoy@fb.com>
> > Suggested-by: Namhyung Kim <namhyung@kernel.org>
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>
> Acked-by: Ian Rogers <irogers@google.com>
Thanks, applied to perf/urgent.
- Arnaldo
next prev parent reply other threads:[~2022-08-31 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 12:40 [PATCH] perf script: Skip dummy event attr check Jiri Olsa
2022-08-31 16:02 ` Ian Rogers
2022-08-31 16:23 ` Arnaldo Carvalho de Melo [this message]
2022-09-07 2:49 ` Xing Zhengjun
2022-09-07 4:50 ` Namhyung Kim
2022-09-07 5:19 ` Xing Zhengjun
2022-09-07 8:09 ` Jiri Olsa
2022-09-07 8:14 ` Namhyung Kim
2022-09-07 14:16 ` Jiri Olsa
2022-09-08 6:56 ` Xing Zhengjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw+LCN2cX9peweWV@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=hoy@fb.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).