From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: Ian Rogers <irogers@google.com>,
linux-perf-users@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: python: Fix build when PYTHON_CONFIG is user supplied
Date: Mon, 22 Aug 2022 10:50:00 -0300 [thread overview]
Message-ID: <YwOJiBG+K877d+Ou@kernel.org> (raw)
In-Reply-To: <f64f6cbf-73cf-e59a-5f6d-7303125bee66@arm.com>
Em Mon, Aug 22, 2022 at 11:08:37AM +0100, James Clark escreveu:
>
>
> On 28/07/2022 20:26, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jul 28, 2022 at 09:37:32AM -0700, Ian Rogers escreveu:
> >> On Thu, Jul 28, 2022 at 2:40 AM James Clark <james.clark@arm.com> wrote:
> >>>
> >>> The previous change to Python autodetection had a small mistake where
> >>> the auto value was used to determine the Python binary, rather than the
> >>> user supplied value. The Python binary is only used for one part of the
> >>> build process, rather than the final linking, so it was producing
> >>> correct builds in most scenarios, especially when the auto detected
> >>> value matched what the user wanted, or the system only had a valid set
> >>> of Pythons.
> >>>
> >>> Change it so that the Python binary path is derived from either the
> >>> PYTHON_CONFIG value or PYTHON value, depending on what is specified by
> >>> the user. This was the original intention.
> >>>
> >>> This error was spotted in a build failure an odd cross compilation
> >>> environment after commit 4c41cb46a732fe82 ("perf python: Prefer
> >>> python3") was merged.
> >>>
> >>> Fixes: 630af16eee495f58 ("perf tools: Use Python devtools for version autodetection rather than runtime")
> >>> Signed-off-by: James Clark <james.clark@arm.com>
> >>
> >> Acked-by: Ian Rogers <irogers@google.com>
> >
> > Thanks, applied.
>
> Hi Arnaldo,
>
> I couldn't find this change in any of your branches. Do you know if it
> got dropped somehow or was there an issue with it?
Applied it to my local perf/urgent branch, testing now. I thought I had
processed it, not really :-\
- Arnaldo
prev parent reply other threads:[~2022-08-22 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 9:39 [PATCH] perf: python: Fix build when PYTHON_CONFIG is user supplied James Clark
2022-07-28 16:37 ` Ian Rogers
2022-07-28 19:26 ` Arnaldo Carvalho de Melo
2022-08-22 10:08 ` James Clark
2022-08-22 13:50 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwOJiBG+K877d+Ou@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).