From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Xin Gao <gaoxin@cdjrlc.com>
Cc: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org,
irogers@google.com, ak@linux.intel.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf parse-events: Variable type completion
Date: Mon, 22 Aug 2022 11:14:27 -0300 [thread overview]
Message-ID: <YwOPQ4rr9eBbrxxx@kernel.org> (raw)
In-Reply-To: <20220816174109.7718-1-gaoxin@cdjrlc.com>
Em Wed, Aug 17, 2022 at 01:41:09AM +0800, Xin Gao escreveu:
> 'unsigned int' is better than 'unsigned'.
Thanks, applied.
- Arnaldo
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> tools/perf/util/pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index f516d3821d28..bc1230f68341 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -1225,7 +1225,7 @@ static char *pmu_formats_string(struct list_head *formats)
> struct perf_pmu_format *format;
> char *str = NULL;
> struct strbuf buf = STRBUF_INIT;
> - unsigned i = 0;
> + unsigned int i = 0;
>
> if (!formats)
> return NULL;
> --
> 2.30.2
--
- Arnaldo
prev parent reply other threads:[~2022-08-22 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 17:41 [PATCH] perf parse-events: Variable type completion Xin Gao
2022-08-22 14:14 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwOPQ4rr9eBbrxxx@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=gaoxin@cdjrlc.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).