From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F58C28D13 for ; Thu, 25 Aug 2022 09:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235388AbiHYJ1y (ORCPT ); Thu, 25 Aug 2022 05:27:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233563AbiHYJ1v (ORCPT ); Thu, 25 Aug 2022 05:27:51 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7BB09E8BB; Thu, 25 Aug 2022 02:27:50 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 8BF8D5BCFF; Thu, 25 Aug 2022 09:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1661419669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oD2ON5ZEmElLgT4EBxpSWyu1ku5LP4DrXwfA23XWjH4=; b=qknJkW1fP0r2UL8UgzODME4WEr79d6P4xEuqkMLZADrhrnaZvBgIbr/L0faRbdiu6dHJmE tvkb1ptlffg/lhWil1eQZUDjhGa6bN1dyT5LO7aJKLLNCh/XcrNqoiWnPzH6p5mvmmoUDQ 3JAdcgDNBV8/4sIoa7uVLdV0TcindVs= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id BBCD22C142; Thu, 25 Aug 2022 09:27:48 +0000 (UTC) Date: Thu, 25 Aug 2022 11:27:46 +0200 From: Petr Mladek To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Tejun Heo , Zefan Li , Johannes Weiner , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Sergey Senozhatsky , Steven Rostedt , John Ogness , John Stultz , Thomas Gleixner , Stephen Boyd , bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH] kernel: move from strlcpy with unused retval to strscpy Message-ID: References: <20220818210202.8227-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220818210202.8227-1-wsa+renesas@sang-engineering.com> Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Thu 2022-08-18 23:02:01, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang > > --- > kernel/acct.c | 2 +- > kernel/bpf/preload/bpf_preload_kern.c | 4 ++-- > kernel/cgroup/cgroup-v1.c | 4 ++-- > kernel/events/core.c | 6 +++--- > kernel/kallsyms.c | 4 ++-- > kernel/params.c | 2 +- > kernel/printk/printk.c | 2 +- > kernel/relay.c | 4 ++-- > kernel/time/clocksource.c | 2 +- > kernel/trace/ftrace.c | 18 +++++++++--------- > kernel/trace/trace.c | 8 ++++---- > kernel/trace/trace_events.c | 2 +- > kernel/trace/trace_events_inject.c | 4 ++-- > kernel/trace/trace_kprobe.c | 2 +- > kernel/trace/trace_probe.c | 2 +- > 15 files changed, 33 insertions(+), 33 deletions(-) This fixes only small part of the kernel code. It would make sense to do a tree-wide change using a script. Would you mind to create one and send it to Linus? You might want to use Coccinelle if a simple sed/awk gets too complicated. See https://www.kernel.org/doc/html/v4.15/dev-tools/coccinelle.html Best Regards, Petr