From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: zhengjun.xing@linux.intel.com
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@intel.com, jolsa@kernel.org,
namhyung@kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, irogers@google.com,
ak@linux.intel.com, kan.liang@linux.intel.com
Subject: Re: [PATCH] perf stat: Fix L2 Topdown metrics disappear for raw events
Date: Fri, 2 Sep 2022 13:53:38 -0300 [thread overview]
Message-ID: <YxI1Eq1XzHf8O4L2@kernel.org> (raw)
In-Reply-To: <20220826140057.3289401-1-zhengjun.xing@linux.intel.com>
Em Fri, Aug 26, 2022 at 10:00:57PM +0800, zhengjun.xing@linux.intel.com escreveu:
> From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
>
> In perf/Documentation/perf-stat.txt, for "--td-level" the default "0" means
> the max level that the current hardware support. So we need initialize the
> stat_config.topdown_level to TOPDOWN_MAX_LEVEL when “--td-level=0” or no
> “--td-level” option. Otherwise, for the hardware with a max level is 2, the
> 2nd level metrics disappear for raw events in this case. The issue cannot
> be observed for the perf stat default or "--topdown" options. This commit
> fixes the raw events issue and removes the duplicated code for the perf
> stat default.
Thanks, applied, sorry for the delay.
- Arnaldo
prev parent reply other threads:[~2022-09-02 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 14:00 [PATCH] perf stat: Fix L2 Topdown metrics disappear for raw events zhengjun.xing
2022-09-02 16:53 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxI1Eq1XzHf8O4L2@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).