From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCHSET 0/5] perf tools: Show per-event lost sample count (v2)
Date: Fri, 2 Sep 2022 16:09:27 -0300 [thread overview]
Message-ID: <YxJU5yfFC0bI545e@kernel.org> (raw)
In-Reply-To: <5466ec6a-e964-ea8a-d253-f7d3d4af4ea1@intel.com>
Em Fri, Sep 02, 2022 at 08:44:25PM +0300, Adrian Hunter escreveu:
> On 1/09/22 22:57, Namhyung Kim wrote:
> > Hello,
> >
> > Now we have PERF_FORMAT_LOST support, add it to perf record and report so that
> > it can show number of lost samples per event. This can be useful if you want
> > to reconstruct number of events from the samples like when using -c option.
> >
> > Changes in v2)
> > * fix id_hdr_size calculation (Adrian)
> > * fix a memory leak
> > * display lost samples even if no samples
> >
> >
> > Currently it adds PERF_RECORD_LOST_SAMPLES at the end of perf data after reading
> > event values by read(2). The perf record unconditionally sets the lost bit if
> > the kernel supports it. Users can see the number with `perf report --stat`.
> >
> > You can get the code from 'perf/report-lost-v2' brach on
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> >
> > Thanks,
> > Namhyung
> >
> > Namhyung Kim (5):
> > perf tools: Print LOST read format in the verbose mode
> > perf record: Set PERF_FORMAT_LOST by default
> > perf record: Read and inject LOST_SAMPLES events
> > perf hist: Add nr_lost_samples to hist_stats
> > perf report: Show per-event LOST SAMPLES stat
>
> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2022-09-02 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 19:57 [PATCHSET 0/5] perf tools: Show per-event lost sample count (v2) Namhyung Kim
2022-09-01 19:57 ` [PATCH 1/5] perf tools: Print LOST read format in the verbose mode Namhyung Kim
2022-09-01 19:57 ` [PATCH 2/5] perf record: Set PERF_FORMAT_LOST by default Namhyung Kim
2022-09-01 19:57 ` [PATCH 3/5] perf record: Read and inject LOST_SAMPLES events Namhyung Kim
2022-09-01 19:57 ` [PATCH 4/5] perf hist: Add nr_lost_samples to hist_stats Namhyung Kim
2022-09-01 19:57 ` [PATCH 5/5] perf report: Show per-event LOST SAMPLES stat Namhyung Kim
2022-09-02 17:44 ` [PATCHSET 0/5] perf tools: Show per-event lost sample count (v2) Adrian Hunter
2022-09-02 19:09 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxJU5yfFC0bI545e@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).