Re: [PATCH 4/4] perf stat: Clean redundant if in process_evlist

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Thu, Sep 22, 2022 at 10:14:38PM +0800, Shang XiaoJing escreveu:
> Since the first if statment is covered by the following one, clean up
> the first if statment.
> 
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
> ---
>  tools/perf/builtin-stat.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index e10595f649bc..ccea5d1e053a 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -899,8 +899,6 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)
>  		evlist__for_each_cpu(evlist_cpu_itr, evsel_list, affinity) {
>  			counter = evlist_cpu_itr.evsel;
>  
> -			if (!counter->reset_group && !counter->errored)
> -				continue;
>  			if (!counter->reset_group)
>  				continue;

Ian, can you please take a look at this one? You added this in:

commit 472832d2c000b9611feaea66fe521055c3dbf17a
Author: Ian Rogers <irogers@google.com>
Date:   Tue Jan 4 22:13:37 2022 -0800

    perf evlist: Refactor evlist__for_each_cpu()

>  try_again_reset:
> -- 
> 2.17.1


- Arnaldo