From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688CFC32771 for ; Mon, 26 Sep 2022 19:29:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229697AbiIZT3X (ORCPT ); Mon, 26 Sep 2022 15:29:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229515AbiIZT3U (ORCPT ); Mon, 26 Sep 2022 15:29:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5C4C98CAF for ; Mon, 26 Sep 2022 12:29:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 447F06123E for ; Mon, 26 Sep 2022 19:29:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77985C433D6; Mon, 26 Sep 2022 19:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664220558; bh=dd4PJJug6S0lh3IVCKUeujY4WoRu7gTAlwK1QGArvfw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DyJL9EqHEJa1IOL8XS7x+/G/haaho4oc3H/3vrn1H4kZuAkeKgowf02GePVilfoDc Sv2EWtKWfiZfnawULSrsCRK1nc/h34HuK/eLW+WfIflFOtYliPTWrI4SRYsZsU3fGV js7S3Cx/Yaq/WqdzR7EZXv7EEwhD9epczfat6bq/i/r0Y7gE/Gh3wMidrCob8htJ/x /07JW2l8NGcZK+NE+RZNSgjPozi8piIirVCC1WOOkr42kX6ImdwYgWOCYvPt9uIil1 JflR77OnGaUF4AjtLfD68p1iEK6wXTzTWgBogb6pNxl++QRH/eKV42vC8QKqM3HgkC GJJ7LB+U27lfg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id B7CFD403B0; Mon, 26 Sep 2022 20:29:15 +0100 (IST) Date: Mon, 26 Sep 2022 20:29:15 +0100 From: Arnaldo Carvalho de Melo To: kajoljain Cc: Athira Rajeev , jolsa@kernel.org, mpe@ellerman.id.au, maddy@linux.vnet.ibm.com, rnsastry@linux.ibm.com, linux-perf-users@vger.kernel.org, disgoel@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH V2] tools/perf/tests: Fix perf probe error log check in skip_if_no_debuginfo Message-ID: References: <20220916104904.99798-1-atrajeev@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Fri, Sep 16, 2022 at 06:35:41PM +0530, kajoljain escreveu: > > > On 9/16/22 16:19, Athira Rajeev wrote: > > The perf probe related tests like probe_vfs_getname.sh which > > is in "tools/perf/tests/shell" directory have dependency on > > debuginfo information in the kernel. Currently debuginfo > > check is handled by skip_if_no_debuginfo function in the > > file "lib/probe_vfs_getname.sh". skip_if_no_debuginfo function > > looks for this specific error log from perf probe to skip > > the testcase: > > > > <<>> > > Failed to find the path for the kernel|Debuginfo-analysis is > > not supported > > <>> > > > > But in some case, like this one in powerpc, while running this > > test, observed error logs is: > > > > <<>> > > The /lib/modules//build/vmlinux file has no debug information. > > Rebuild with CONFIG_DEBUG_INFO=y, or install an appropriate debuginfo > > package. > > Error: Failed to add events. > > <<>> > > > > Update the skip_if_no_debuginfo function to include the above > > error, to skip the test in these scenarios too. > > Patch looks good to me. > > Reviewed-By: Kajol Jain Thanks, applied. - Arnaldo > Thanks, > Kajol Jain > > > > > Reported-by: Disha Goel > > Signed-off-by: Athira Rajeev > > --- > > changelog: > > v1 -> v2: > > Corrected formatting of spaces in error log. > > With spaces in v1 of the patch, the egrep search was > > considering spaces also. > > > > tools/perf/tests/shell/lib/probe_vfs_getname.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/tests/shell/lib/probe_vfs_getname.sh b/tools/perf/tests/shell/lib/probe_vfs_getname.sh > > index 5b17d916c555..b616d42bd19d 100644 > > --- a/tools/perf/tests/shell/lib/probe_vfs_getname.sh > > +++ b/tools/perf/tests/shell/lib/probe_vfs_getname.sh > > @@ -19,6 +19,6 @@ add_probe_vfs_getname() { > > } > > > > skip_if_no_debuginfo() { > > - add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for the kernel|Debuginfo-analysis is not supported)" && return 2 > > + add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for the kernel|Debuginfo-analysis is not supported)|(file has no debug information)" && return 2 > > return 1 > > } -- - Arnaldo