From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Zhengjun Xing <zhengjun.xing@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
perry.taylor@intel.com, caleb.biggers@intel.com,
kshipra.bopardikar@intel.com, samantha.alt@intel.com,
ahmad.yasin@intel.com, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
John Garry <john.garry@huawei.com>,
James Clark <james.clark@arm.com>,
Kajol Jain <kjain@linux.ibm.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Miaoqian Lin <linmq006@gmail.com>,
Florian Fischer <florian.fischer@muhq.space>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v3 00/23] Improvements to Intel perf metrics
Date: Tue, 4 Oct 2022 09:09:01 -0300 [thread overview]
Message-ID: <YzwiXfWNbLM0et3A@kernel.org> (raw)
In-Reply-To: <20221004021612.325521-1-irogers@google.com>
Em Mon, Oct 03, 2022 at 07:15:49PM -0700, Ian Rogers escreveu:
> For consistency with:
> https://github.com/intel/perfmon-metrics
> rename of topdown TMA metrics from Frontend_Bound to tma_frontend_bound.
>
> Remove _SMT suffix metrics are dropped as the #SMT_On and #EBS_Mode
> are correctly expanded in the single main metric. Fix perf expr to
> allow a double if to be correctly processed.
>
> Add all 6 levels of TMA metrics. Child metrics are placed in a group
> named after their parent allowing children of a metric to be
> easily measured using the metric name with a _group suffix.
>
> Don't drop TMA metrics if they contain topdown events.
>
> The ## and ##? operators are correctly expanded.
>
> The locate-with column is added to the long description describing a
> sampling event.
>
> Metrics are written in terms of other metrics to reduce the expression
> size and increase readability.
>
> Following this the pmu-events/arch/x86 directories match those created
> by the script at:
> https://github.com/intel/event-converter-for-linux-perf/blob/master/download_and_gen.py
> with updates at:
> https://github.com/captain5050/event-converter-for-linux-perf
>
>
> v3. Fix a parse metrics test failure due to making metrics referring
> to other metrics case sensitive - make the cases in the test
> metric match.
Thanks, applied.
- Arnaldo
> v2. Fixes commit message wrt missing mapfile.csv updates as noted by
> Zhengjun Xing <zhengjun.xing@linux.intel.com>. ScaleUnit is added
> for TMA metrics. Metrics with topdown events have have a missing
> slots event added if necessary. The latest metrics at:
> https://github.com/intel/perfmon-metrics are used, however, the
> event-converter-for-linux-perf scripts now prefer their own
> metrics in case of mismatched units when a metric is written in
> terms of another. Additional testing was performed on broadwell,
> broadwellde, cascadelakex, haswellx, sapphirerapids and tigerlake
> CPUs.
>
> Ian Rogers (23):
> perf expr: Allow a double if expression
> perf test: Adjust case of test metrics
> perf expr: Remove jevents case workaround
> perf metrics: Don't scale counts going into metrics
> perf vendor events: Update Intel skylakex
> perf vendor events: Update Intel alderlake
> perf vendor events: Update Intel broadwell
> perf vendor events: Update Intel broadwellx
> perf vendor events: Update Intel cascadelakex
> perf vendor events: Update elkhartlake cpuids
> perf vendor events: Update Intel haswell
> perf vendor events: Update Intel haswellx
> perf vendor events: Update Intel icelake
> perf vendor events: Update Intel icelakex
> perf vendor events: Update Intel ivybridge
> perf vendor events: Update Intel ivytown
> perf vendor events: Update Intel jaketown
> perf vendor events: Update Intel sandybridge
> perf vendor events: Update Intel sapphirerapids
> perf vendor events: Update silvermont cpuids
> perf vendor events: Update Intel skylake
> perf vendor events: Update Intel tigerlake
> perf vendor events: Update Intel broadwellde
>
> .../arch/test/test_soc/cpu/metrics.json | 6 +-
> .../arch/x86/alderlake/adl-metrics.json | 1353 ++++++++++++++++-
> .../pmu-events/arch/x86/alderlake/cache.json | 129 +-
> .../arch/x86/alderlake/frontend.json | 12 +
> .../pmu-events/arch/x86/alderlake/memory.json | 22 +
> .../pmu-events/arch/x86/alderlake/other.json | 22 +
> .../arch/x86/alderlake/pipeline.json | 14 +-
> .../arch/x86/broadwell/bdw-metrics.json | 679 +++++++--
> .../arch/x86/broadwellde/bdwde-metrics.json | 711 +++++++--
> .../arch/x86/broadwellx/bdx-metrics.json | 965 +++++++-----
> .../arch/x86/broadwellx/uncore-cache.json | 10 +-
> .../x86/broadwellx/uncore-interconnect.json | 18 +-
> .../arch/x86/broadwellx/uncore-memory.json | 18 +-
> .../arch/x86/cascadelakex/clx-metrics.json | 1285 ++++++++++------
> .../arch/x86/cascadelakex/uncore-memory.json | 18 +-
> .../arch/x86/cascadelakex/uncore-other.json | 10 +-
> .../pmu-events/arch/x86/haswell/cache.json | 4 +-
> .../pmu-events/arch/x86/haswell/frontend.json | 12 +-
> .../arch/x86/haswell/hsw-metrics.json | 570 ++++++-
> .../pmu-events/arch/x86/haswellx/cache.json | 2 +-
> .../arch/x86/haswellx/frontend.json | 12 +-
> .../arch/x86/haswellx/hsx-metrics.json | 919 +++++++----
> .../x86/haswellx/uncore-interconnect.json | 18 +-
> .../arch/x86/haswellx/uncore-memory.json | 18 +-
> .../pmu-events/arch/x86/icelake/cache.json | 6 +-
> .../arch/x86/icelake/icl-metrics.json | 808 +++++++++-
> .../pmu-events/arch/x86/icelake/pipeline.json | 2 +-
> .../pmu-events/arch/x86/icelakex/cache.json | 6 +-
> .../arch/x86/icelakex/icx-metrics.json | 1155 ++++++++++----
> .../arch/x86/icelakex/pipeline.json | 2 +-
> .../arch/x86/icelakex/uncore-other.json | 2 +-
> .../arch/x86/ivybridge/ivb-metrics.json | 594 ++++++--
> .../pmu-events/arch/x86/ivytown/cache.json | 4 +-
> .../arch/x86/ivytown/floating-point.json | 2 +-
> .../pmu-events/arch/x86/ivytown/frontend.json | 18 +-
> .../arch/x86/ivytown/ivt-metrics.json | 630 ++++++--
> .../arch/x86/ivytown/uncore-cache.json | 58 +-
> .../arch/x86/ivytown/uncore-interconnect.json | 84 +-
> .../arch/x86/ivytown/uncore-memory.json | 2 +-
> .../arch/x86/ivytown/uncore-other.json | 6 +-
> .../arch/x86/ivytown/uncore-power.json | 8 +-
> .../arch/x86/jaketown/jkt-metrics.json | 327 +++-
> tools/perf/pmu-events/arch/x86/mapfile.csv | 18 +-
> .../arch/x86/sandybridge/snb-metrics.json | 315 +++-
> .../arch/x86/sapphirerapids/cache.json | 4 +-
> .../arch/x86/sapphirerapids/frontend.json | 11 +
> .../arch/x86/sapphirerapids/pipeline.json | 4 +-
> .../arch/x86/sapphirerapids/spr-metrics.json | 1249 ++++++++++-----
> .../arch/x86/skylake/skl-metrics.json | 861 ++++++++---
> .../arch/x86/skylakex/skx-metrics.json | 1262 +++++++++------
> .../arch/x86/skylakex/uncore-memory.json | 18 +-
> .../arch/x86/skylakex/uncore-other.json | 19 +-
> .../arch/x86/tigerlake/tgl-metrics.json | 810 +++++++++-
> tools/perf/pmu-events/empty-pmu-events.c | 6 +-
> tools/perf/tests/expr.c | 4 +
> tools/perf/util/expr.c | 11 +-
> tools/perf/util/expr.y | 2 +-
> tools/perf/util/stat-shadow.c | 9 +-
> 58 files changed, 11514 insertions(+), 3630 deletions(-)
>
> --
> 2.38.0.rc1.362.ged0d419d3c-goog
--
- Arnaldo
prev parent reply other threads:[~2022-10-04 12:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 2:15 [PATCH v3 00/23] Improvements to Intel perf metrics Ian Rogers
2022-10-04 2:15 ` [PATCH v3 01/23] perf expr: Allow a double if expression Ian Rogers
2022-10-04 2:15 ` [PATCH v3 02/23] perf test: Adjust case of test metrics Ian Rogers
2022-10-04 2:15 ` [PATCH v3 03/23] perf expr: Remove jevents case workaround Ian Rogers
2022-10-04 2:15 ` [PATCH v3 04/23] perf metrics: Don't scale counts going into metrics Ian Rogers
2022-10-04 2:15 ` [PATCH v3 07/23] perf vendor events: Update Intel broadwell Ian Rogers
2022-10-04 2:15 ` [PATCH v3 10/23] perf vendor events: Update elkhartlake cpuids Ian Rogers
2022-10-04 2:16 ` [PATCH v3 11/23] perf vendor events: Update Intel haswell Ian Rogers
2022-10-04 2:16 ` [PATCH v3 13/23] perf vendor events: Update Intel icelake Ian Rogers
2022-10-04 2:16 ` [PATCH v3 15/23] perf vendor events: Update Intel ivybridge Ian Rogers
2022-10-04 2:16 ` [PATCH v3 17/23] perf vendor events: Update Intel jaketown Ian Rogers
2022-10-04 2:16 ` [PATCH v3 18/23] perf vendor events: Update Intel sandybridge Ian Rogers
2022-10-04 2:16 ` [PATCH v3 20/23] perf vendor events: Update silvermont cpuids Ian Rogers
2022-10-04 2:16 ` [PATCH v3 22/23] perf vendor events: Update Intel tigerlake Ian Rogers
2022-10-04 2:16 ` [PATCH v3 23/23] perf vendor events: Update Intel broadwellde Ian Rogers
2022-10-04 3:43 ` [PATCH v3 00/23] Improvements to Intel perf metrics Ian Rogers
2022-10-04 17:28 ` Andi Kleen
2022-10-04 17:55 ` Ian Rogers
2022-10-04 18:09 ` Arnaldo Carvalho de Melo
2022-10-04 18:15 ` Andi Kleen
2022-10-04 18:26 ` Arnaldo Carvalho de Melo
2022-10-04 12:09 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzwiXfWNbLM0et3A@kernel.org \
--to=acme@kernel.org \
--cc=ahmad.yasin@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=eranian@google.com \
--cc=florian.fischer@muhq.space \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=kshipra.bopardikar@intel.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
--cc=tmricht@linux.ibm.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).