From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Leo Yan <leo.yan@linaro.org>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
James Clark <james.clark@arm.com>
Subject: Re: [PATCHSET 0/7] perf stat: Small random cleanups (v2)
Date: Tue, 4 Oct 2022 15:48:35 -0300 [thread overview]
Message-ID: <YzyAA/RaIGoxCbGI@kernel.org> (raw)
In-Reply-To: <20220930202110.845199-1-namhyung@kernel.org>
Em Fri, Sep 30, 2022 at 01:21:03PM -0700, Namhyung Kim escreveu:
> Hello,
>
> I'm working on perf stat and I found some items to clean up. This time
> I removed runtime stats for per-thread aggregation mode which we can simply
> use thread map index to compare the shadow stat values in the rt_stat.
>
> Changes from v1)
> * renaming missing parts in headers (James)
> * add a comment for map_idx (Ian)
> * add Reviewed-by from James
>
> The code is available at 'perf/stat-cleanup-v2' branch in
>
> git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Applied locally, testing.
- Arnaldo
> Thanks,
> Namhyung
>
>
> Namhyung Kim (7):
> perf stat: Convert perf_stat_evsel.res_stats array
> perf stat: Don't call perf_stat_evsel_id_init() repeatedly
> perf stat: Rename saved_value->cpu_map_idx
> perf stat: Use thread map index for shadow stat
> perf stat: Kill unused per-thread runtime stats
> perf stat: Don't compare runtime stat for shadow stats
> perf stat: Rename to aggr_cpu_id.thread_idx
>
> tools/perf/builtin-stat.c | 54 ------
> tools/perf/tests/topology.c | 10 +-
> tools/perf/util/cpumap.c | 8 +-
> tools/perf/util/cpumap.h | 2 +-
> tools/perf/util/stat-display.c | 32 ++--
> tools/perf/util/stat-shadow.c | 320 ++++++++++++++++-----------------
> tools/perf/util/stat.c | 20 +--
> tools/perf/util/stat.h | 10 +-
> 8 files changed, 189 insertions(+), 267 deletions(-)
>
>
> base-commit: 62e64c9d2fd12839c02f1b3e8b873e7cb34e8720
> --
> 2.38.0.rc1.362.ged0d419d3c-goog
--
- Arnaldo
prev parent reply other threads:[~2022-10-04 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 20:21 [PATCHSET 0/7] perf stat: Small random cleanups (v2) Namhyung Kim
2022-09-30 20:21 ` [PATCH 1/7] perf stat: Convert perf_stat_evsel.res_stats array Namhyung Kim
2022-09-30 20:21 ` [PATCH 2/7] perf stat: Don't call perf_stat_evsel_id_init() repeatedly Namhyung Kim
2022-09-30 20:21 ` [PATCH 3/7] perf stat: Rename saved_value->cpu_map_idx Namhyung Kim
2022-09-30 20:21 ` [PATCH 4/7] perf stat: Use thread map index for shadow stat Namhyung Kim
2022-09-30 20:21 ` [PATCH 5/7] perf stat: Kill unused per-thread runtime stats Namhyung Kim
2022-09-30 20:21 ` [PATCH 6/7] perf stat: Don't compare runtime stat for shadow stats Namhyung Kim
2022-09-30 20:21 ` [PATCH 7/7] perf stat: Rename to aggr_cpu_id.thread_idx Namhyung Kim
2022-10-04 18:48 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzyAA/RaIGoxCbGI@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).